Bugfix, route prefix was always set to false after calling nest

[mendelt]

Description

I found this method in route.rs:

    pub fn nest<InnerState>(&mut self, service: crate::Server<InnerState>) -> &mut Self
    where
        State: Clone + Send + Sync + 'static,
        InnerState: Clone + Send + Sync + 'static,
    {
        self.prefix = true;
        self.all(service);
        self.prefix = false;
        self
    }

I'm not sure if this is expected behavior but I assume that if self.prefix was set to true before calling nest it should stay true.

How Has This Been Tested?

This is a trivial code change, all tests still pass, however I could try to add a regression test for this. Let me know if this is required

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

This does introduce a small change in behavior but it only impacts code that uses the unstable strip-prefix method

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[yoshuawuyts]

Thanks so much for this PR! Yeah this is indeed a great fix!

A regression test would be great though, as this is an easy thing to miss. Also if we could split 3d41fb9 from 2ad051a into separate patches that'd be greatly appreciated. Also we've fixed the tests on main, which means 3a25c85 is no longer needed.

[mendelt]

Thank you, the two branches for #700 and this pr are now both based on main so they don't depend on each other anymore. And I removed the test fixes from #700
I'll let you know when I get around to adding the regression test.

[mendelt]

Hmm.. I looked at testing this, but don't see how to do that the way tests are set up. The prefix flags is not accessible from outside the Route struct and to test this we need to call the unstable nest function. Not sure how to proceed.

[yoshuawuyts]

It's okay if we can't test it; happy enough to merge this as-is. Thanks heaps!