Merged
Conversation
yoshuawuyts
approved these changes
Mar 26, 2021
Member
yoshuawuyts
left a comment
There was a problem hiding this comment.
The tradeoffs seem reasonable; I'd be in favor of merging this
Member
|
@jbr Status of this? |
Member
Author
|
I feel good about this personally, but have hesitations about switching over to it without anyone else playing with it at all, since it's a ground-up rewrite. This is technically a breaking change but I don't have a great sense of how many people would notice any change other than a perf improvement |
Member
|
If you can fix the rebase I'll see if I can use it a bit (not quite sure when tho) |
Member
Author
|
@Fishrock123 rebased |
Open
Fishrock123
approved these changes
Sep 16, 2021
Member
Fishrock123
left a comment
There was a problem hiding this comment.
I feel pretty strongly that we should go forward with this as part of a 0.17
Member
|
Released as 0.17.0-beta.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
routefinder represents a complete rewrite of the route-recognizer behavior
Breaking changes:
There may be an incidental performance improvement of several microseconds per request
closes #783
a step towards #797