Open
Conversation
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
950f8d0 to
8817761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
url_mutmethod counterpart similar to how it's done for other components, e.g. https://docs.rs/tide/latest/tide/struct.Request.html#method.session_mutMade sure the documentation is consistent with upstream library used https://docs.rs/http-types/latest/http_types/struct.Request.html#method.url
This is useful, for example, in cases where prefix of a route can contain forward-slashes and a request is to be routed to a nested server and custom routing relying on
responsemethod needs to be implemented.For example, if
/a/b/c/_myrouteand/a/_myrouteshould call the same route on someServer, then an outerServerimplementation could add a route on*, parse the URI from the request, trim the prefix as required and pass the request with modified URI (viaurl_mut) to the nestedServerviaServer::respond