fix(auth): decode percent-encoded credentials from URL#1714
Closed
gilangjavier wants to merge 1 commit intohttpie:masterfrom
Closed
fix(auth): decode percent-encoded credentials from URL#1714gilangjavier wants to merge 1 commit intohttpie:masterfrom
gilangjavier wants to merge 1 commit intohttpie:masterfrom
Conversation
Author
|
Closing this PR because multiple other PRs are already addressing issue #1623. I'll work on a different issue to avoid duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1623.
When credentials are provided via URL userinfo (e.g. https://u%40d:...@host/...), HTTPie should decode percent-encoded characters before constructing Basic Auth credentials.
Added a regression test covering percent-encoded username/password in the URL.