Add .movedTemporarily case (HTTP 307) to HttpResponse#352
Merged
adamkaplan merged 1 commit intohttpswift:stablefrom Dec 6, 2018
Merged
Add .movedTemporarily case (HTTP 307) to HttpResponse#352adamkaplan merged 1 commit intohttpswift:stablefrom
adamkaplan merged 1 commit intohttpswift:stablefrom
Conversation
adamkaplan
approved these changes
Dec 6, 2018
Collaborator
adamkaplan
left a comment
adamkaplan
left a comment
There was a problem hiding this comment.
This looks good to me. If you want to add 302, that would also be pretty cool. I don't think you should need to resubmit this PR though, because 307 is totally valid.
Member
|
@adamkaplan I was thinking about a strategy to support more default status code and HTTP headers as we have a lot of request of this kind of behavior so far. We have the custom one but maybe if we're supporting only a subset we should be creating it little by little more of them. What do you think? |
Collaborator
|
That sounds reasonable to me. There are quite a few codes, pretty large amount of work. Could use a formal strategy |
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
Add .movedTemporarily case (HTTP 307) to HttpResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm currently working on prototype based on Swifter and I needed a temporary redirect which I've now commited to my fork.
Do you think this could be useful to integrate in the main repo?
I've used HTTP 307 as I don't need to change the HTTP method on the redirect but if you think that it is a common scenario I'd be happy to change it to 302 and resubmit the PR.