Skip to content

Add support for CircleCI#364

Merged
Vkt0r merged 1 commit intohttpswift:stablefrom
Vkt0r:ci-integration
Mar 12, 2019
Merged

Add support for CircleCI#364
Vkt0r merged 1 commit intohttpswift:stablefrom
Vkt0r:ci-integration

Conversation

@Vkt0r
Copy link
Copy Markdown
Member

@Vkt0r Vkt0r commented Jan 29, 2019 •
edited
Loading

This PR adds support for CI using CircleCI and can be resumed in the following:

  • Add the new config.yml file with testing for tvOS, macOS and iOS and SPM for Linux and macOS.
  • Reorganize the tests targets and replace the import for the @testable in the test targets.
  • Add the test target in the Package.swift.
  • Include the LinuxMain.swift for the SPM run the tests on Linux.
  • Fix the issue with the use of Darwing in Linux.

This PR is currently a work in progress to solve #349.

@Vkt0r Vkt0r changed the base branch from stable to master January 31, 2019 03:25
@Vkt0r Vkt0r changed the base branch from master to stable January 31, 2019 03:26
@Vkt0r Vkt0r force-pushed the ci-integration branch 5 times, most recently from 9711e31 to cf5d799 Compare February 1, 2019 23:21
@Vkt0r
Copy link
Copy Markdown
Member Author

Vkt0r commented Feb 1, 2019

Tests in macOS, iOS & tvOS are green. On Linux we have a failing test:

IOSafetyTests.testStopWithActiveConnections

with the following message:

failed - 1: bindFailed("Address already in use")

With the first observation around it, I think something is not properly working with Dispatch or something else in Linux as it should be. More investigation is needed here. Any thoughts @adamkaplan @julien-c @glock45 🤔 ?

@Vkt0r
Add support for CircleCI
2a2ef09 
• Add the new circle.yml file with testing for tvOS, macOS and iOS and SPM for Linux and macOS
• Reorganize the tests targets and replace the `import` for the `@testable` in the test targets
• Add the test target in the Package.swift
• Include the LinuxMain for the SPM run the tests on Linux
• Fix the issue with the use of Darwing in Linux
@Vkt0r
Copy link
Copy Markdown
Member Author

Vkt0r commented Feb 14, 2019

The current failing test IMHO is very low priority as I'm afraid is a problem with the platform and how GCD and Semaphores are working in Linux. For the moment I'll remove it from the running tests in Linux and we can open an issue and come back to fix it later at some point. The issue number is #366.

@Vkt0r Vkt0r requested a review from adamkaplan February 14, 2019 15:53
@Vkt0r
Copy link
Copy Markdown
Member Author

Vkt0r commented Feb 19, 2019

@adamkaplan When you have time can you take a look, please ? With this PR we can ensure stability in our coming PRs.

@Vkt0r Vkt0r changed the title [WIP] Add support for CircleCI Add support for CircleCI Feb 20, 2019
@Vkt0r
Copy link
Copy Markdown
Member Author

Vkt0r commented Mar 1, 2019

@adamkaplan 🙏 Please when you have time can you take a look?

@Vkt0r
Copy link
Copy Markdown
Member Author

Vkt0r commented Mar 12, 2019 •
edited
Loading

I'm merging this as this would not break compatibility and it has been in review for some time now. We had an issue opened to track the failing test in Linux. We can rollback in case of an issue.

@Vkt0r Vkt0r merged commit c3231ac into httpswift:stable Mar 12, 2019
@Vkt0r Vkt0r deleted the ci-integration branch March 12, 2019 14:39
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#364 from Vkt0r/ci-integration
cd56ddb 
Add support for CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamkaplan adamkaplan Awaiting requested review from adamkaplan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Vkt0r