Add the node_id to the Discussion Category payload#1335
Merged
bitwiseman merged 1 commit intohub4j:mainfrom Dec 2, 2021
Merged
Add the node_id to the Discussion Category payload#1335bitwiseman merged 1 commit intohub4j:mainfrom
bitwiseman merged 1 commit intohub4j:mainfrom
Conversation
I reported the fact that the field was missing to the GitHub team and they were kind enough to add it so we can now take it into account.
Codecov Report
@@ Coverage Diff @@
## main #1335 +/- ##
=========================================
Coverage 78.17% 78.18%
Complexity 2045 2045
=========================================
Files 200 200
Lines 6283 6284 +1
Branches 356 356
=========================================
+ Hits 4912 4913 +1
Misses 1162 1162
Partials 209 209
Continue to review full report at Codecov.
|
bitwiseman
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reported the fact that the field was missing to the GitHub team and
they were kind enough to add it so we can now take it into account.
The numeric id is not exposed at all in the GraphQL API and neither in the UI so if you want to reference an id, it's kinda problematic right now, you have to generate payloads and get the id from there.
With this addition, you will be able to reference the node_id which is present in the GraphQL API.