Skip to content

Fix GHTeam#remove(GHUser) and add tests#1438

Merged
bitwiseman merged 3 commits intohub4j:mainfrom
gsmet:fix-team-remove
Apr 21, 2022
Merged

Fix GHTeam#remove(GHUser) and add tests#1438
bitwiseman merged 3 commits intohub4j:mainfrom
gsmet:fix-team-remove

Conversation

@gsmet
Copy link
Copy Markdown
Contributor

@gsmet gsmet commented Apr 21, 2022

I included the original commit of #1437 with the original author (just reworded the commit message for more clarity).

My advice would be to release something right away as this could be considered as a security issue given we are not removing people from teams appropriately.

Note that it was broken anyway since GH retired the old Teams API.

Comment thread src/main/java/org/kohsuke/github/GHTeam.java
@gsmet gsmet mentioned this pull request Apr 21, 2022
10 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2022

Codecov Report

Merging #1438 (d870d21) into main (0365965) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1438      +/-   ##
============================================
+ Coverage     78.65%   78.77%   +0.12%     
- Complexity     2097     2100       +3     
============================================
  Files           201      201              
  Lines          6389     6390       +1     
  Branches        359      359              
============================================
+ Hits           5025     5034       +9     
+ Misses         1157     1149       -8     
  Partials        207      207              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHTeam.java 83.52% <100.00%> (+9.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0365965...d870d21. Read the comment docs.

@bitwiseman bitwiseman merged commit fab5137 into hub4j:main Apr 21, 2022
@gsmet
Copy link
Copy Markdown
Contributor Author

gsmet commented Apr 21, 2022

Thanks for the quick release @bitwiseman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants