Skip to content

Comments

Collections UI#1399

Merged
yuanzhou merged 4 commits intodev-integratefrom
collectionsUI
May 3, 2024
Merged

Collections UI#1399
yuanzhou merged 4 commits intodev-integratefrom
collectionsUI

Conversation

@BirdMachine
Copy link
Contributor

Updates to Ownership Group assignment/selection
Replaces Delineated Contacts/contributors table with a combined table using a column for Contact status rendering
Various fixes to table columns and values rendering

…ng definitions.

Provides Group Selection modal on Collection creation to assign an ownership group.
Stops the idle timer when the REACT_APP_URL is http://localhost:8585
Fix generation of Action column for the Associated Entity table to reduce re-rendering calls
@BirdMachine BirdMachine requested a review from yuanzhou May 2, 2024 22:29
resolve();
}, 2000);
});
if(process.env.REACT_APP_URL == "http://localhost:8585"){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BirdMachine is this for your local testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially. Added here Figuring out the Re Rendering that was getting in my way involved a lot of alt tabbed research (Especially since the 'bug' was also causing my React Dev Tools to Crash. The Timeout is short and having to log in each time a local or a dev tab was left open for a bit complicates things.
Will touch base on slack for a possibly slicker solution

@yuanzhou yuanzhou merged commit d6efc52 into dev-integrate May 3, 2024
@yuanzhou yuanzhou mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants