Repository navigation
Conversation
…ph-ai main The original PR branch had no common ancestor with main, so the diff read as 'deleted every upstream root file' (.asf.yaml, upstream CI workflows, issue templates, .licenserc.yaml, ...) and the PR conflicted with main. Rebuild instead: branch from apache/main and overlay the module in place at ontogeny/ (server, extensions, web, domains, tests, tools, deploy). - upstream root files, workflows and NOTICE are untouched except three additive touches: README section, NOTICE module line, .gitignore block - the standalone-repo 'structure merge' step (vendoring upstream into third_party/) is dropped for this PR: in the upstream monorepo the modules already live here, a third_party copy would duplicate them all - stage-1 isolation invariant keeps an enforcement: the new ontogeny-ci.yml zero-coupling gate (explicit if-grep-exit-1, replacing the never-failing '!' form) asserts ontogeny does not import hugegraph_llm/hugegraph_ml until the step-2 feature merge - ruff: module now lints under the ROOT config (nested [tool.ruff] removed; 'ontogeny' added to known-first-party; ontogeny/domains excluded as user-code-as-data)
~304 files converted to the repository's ASF header style (the module previously used a plain 'Copyright 2026 Apache HugeGraph Authors' notice, which is not the header .licenserc.yaml enforces); yaml/workflows/sh/ Dockerfile/ts/tsx/html/css covered, binaries and md/json/txt skipped per licenserc paths-ignore. .licenserc.yaml additionally ignores generated lockfiles (uv.lock / package-lock.json).
…ession deletion guards - policy engine: parse and enforce Cedar 'forbid' statements -- a matching forbid now OVERRIDES a matching permit (it used to be silently dropped, turning authored denies into no-ops); publish-time POLICY-FORBID error refuses unparseable forbid statements instead of skipping them; the never-implemented cedarpy preference claim and its extra are removed - validator: DERIVED-MARKING -- a derived property computed from a marked property must declare an equal-or-stricter marking, else publish fails (derived values used to return raw results on every read surface) - broker: session deletion is guarded -- a session carrying approval records is a governance trail and is never deletable via the API; a session without records may only be deleted by its own driver or an admin (any authenticated driver could delete any session before) 11 new regression tests; full suite 572 passed
…ars, demo env respect, admin lockout self-heal, bounded reads, sandbox stdout isolation - projection rebuild: keyset pagination by PK replaces the silent 10k-row truncation without ORDER BY (edges used to reference vertices that were never written) - builder: inline backing.store_spec sidecars are actually written to stores/<name>.yaml now (the writer re-readed the already-parsed spec, so saving an object with a new backing store failed validation) - cli --demo: operator-preset env wins (setdefault) -- demo paths used to clobber ONTOGENY_DB_DSN and lose edits outside the /data volume - auth: demoting/disabling the last ACTIVE administrator is refused (counted excluding the row itself); ensure_admin self-heals an existing-but-demoted bootstrap account instead of crashing at boot - api: bounded reads -- QueryBody.limit/offset and TraverseBody depth/ids/path carry pydantic bounds; the query service and the broker's sessionless search clamp limits too (the MCP surface builds args without pydantic) - sandbox: user print() no longer corrupts the JSON protocol stream -- child binds the protocol to the real stdout at startup and redirects user stdout to stderr (RPC included); the parent turns stray non-JSON lines into SandboxError instead of an uncaught JSONDecodeError 10 new regression tests; full suite 582 passed
- Execute/Validate buttons disable while the mutation is pending, and execute auto-mints an idempotency key per intent: two rapid clicks share one key (the server's unique index dedupes the replay), a click after settle gets a fresh key, and an operator-typed key always wins - parameterized routes (/objects/:type, /objects/:type/:id, /actions/:name, /functions/:name) remount on param change via a KeyedRoute wrapper -- React used to reuse the component, so action B could start with (and execute with) action A's inputs and idempotency state
The root ruff workflow runs format+check on the whole tree; the module now passes both under the root config (select E,F,W,I,C,N,UP,B,SIM,T20,RUF): - 121 files reformatted; ~140 findings fixed by hand or autofix (isort ordering, contextlib.suppress, raise-from chains, ClassVar, context-closure binding in bench tooling, exception-name suffixes, alias hygiene in tests) - root per-file-ignores extended in the repository's existing style: B008 for the FastAPI shell (Depends/Field defaults), T20 for tests and console tools, N815 for the DSL's camelCase wire fields, E501 for prompt/string literals where wrapping would change the text, SIM117 for nested MCP client contexts - core/__init__ resource re-exports declared in __all__ Full suite 582 passed
…d upstream-module roadmap - root README replaced with the ontogeny-branded README (the module's, adapted to monorepo paths): naming thesis, arch board, features, quick start (docker/source), MCP agent guide, production notes - all five referenced screenshots regenerated and committed under ontogeny/docs/en/img/ (dashboard, arch board, ontology canvas, audit stream, agent console with a pending-approval queue) — every image link resolves to a tracked file - new 'Modules' section keeps the five existing hugegraph-ai modules (hugegraph-llm/mcp/ml, python-client, vermeer) with their roles in Ontogeny's integration roadmap: they are being integrated step by step as Ontogeny's core capability modules for graph construction (KG-from-text) and graph reasoning (GraphRAG), under Ontogeny's governance and behind the zero-coupling gate until each stage lands - upstream community sections preserved (contributing incl. AI guidelines, code quality, related projects, license, contact) - module README: fix ./LICENSE -> ../LICENSE (root of the monorepo)
The rebuild onto apache/main dropped the module's docs/ tree (bilingual architecture/usage chapters, the hugegraph-ai merge plan) and the README's referenced screenshots; the five PNGs that did land were captured while logged out, so the README rendered a login page. This restores the full docs tree (en+zh) from the standalone-repo branch and retakes all eleven screenshots against the current UI (1440x900, zh locale, seeded demo data, real audit trail, live test-run result, agent dock open).
- bootstrap admin: no fixed published password; generate a random one and
print it once when ONTOGENY_ADMIN_PASSWORD is unset
- /functions/{name}/invoke: require authentication (was unauthenticated)
- execute response: the returned after-state is masked per the caller's
principal (raw stored row used to leak marked properties)
- MCP session tool calls: pass the resolved MCP driver to call_tool so
steps record WHO drove, not just the plugin identity
- T0 eval gate: a package with zero eval suites no longer passes vacuously
(passed starts False when there is no evidence)
- promotion: refuse to promote a proposal whose status is not
proposed/evaluated (promoted/superseded/rejected can no longer re-ride)
- ALTER TABLE ADD COLUMN: quote the column identifier (a property named
after a SQL keyword stored fine but crashed the additive migration)
…sword print; ruff/format clean; full suite 582
- auth: no published default admin password (random fallback printed once)
- policy: anonymous visitor can no longer ride unscoped permits
- evolve: re-promotion refused; zero-suite eval reports rejected (T0 needs
at least one green suite); post-merge rollback called with pkg_root
- api: /functions invoke requires authentication + honors optional
Action::"invoke-<fn>" Cedar permits
- action: idempotency replay scoped to action+principal
- outbox: dispatch horizon guards the Postgres commit-order id skip
- sources: watermark keyset orders by the watermark column on SQLite too
- ddl: table name quoted in additive ALTER
- declarative http: deployment ${VAR} resolves before caller params; a
parameter can no longer inject a new ${...} reference
- broker: session-creation budget overrides may only tighten the plugin
default; engine drive terminates on AGENT_SESSION_EXPIRED and friends
- repo: filter and sort on marked properties rejected for principals
without the claim (mask binary-search oracle closed)
…d, column-collision check, execute-response masking; README EN screenshots; Palantir references rewritten - validator: DERIVED-MARKING (derived from a marked property must declare an equal-or-stricter marking); DUP-COLUMN (two properties collapsing to one snake-case column); POLICY-RESOURCE (resource-scoped permit/forbid statements are unsupported and fail closed, both at publish and in the engine parser) - policy: unscoped permits no longer grant the anonymous fallback principal - api: execute responses pass through the policy mask like every read - tests: security tests carry the module-internal package path; promote tests pass non-empty suite results - docs: full Palantir mentions rewritten into original phrasing; all 11 README screenshots retaken against the English UI
…zens' and 'fully open' phrasing
… path safety, npm update - ruff: CI uses ruff>=0.11 which formats differently from 0.6.x; reformatted 41 files with ruff 0.17.1 to match CI - licenserc: cedar/sql/svg/dockerignore/Dockerfile are data or config files, not source code; added to paths-ignore - CodeQL: loader.resolve() and service.py path resolution now explicitly .resolve() to normalize against traversal components - npm: updated all web console packages to latest patched versions (245 vitest + build still green) to address dependency-review findings on vulnerable transitive deps
Ruff (51 errors -> 0):
- 48 RUF059/RUF043/RUF046 auto-fixed (--unsafe-fixes): unused unpacked
variables in tests prefixed with underscore
- 3 hand-fixed: RUF034 useless if-else in effective_owner, RUF043
non-raw match patterns in two test files
certifi critical CVE (GHSA-6q48-6c7w-9gw2):
- uv.lock removed (it pinned certifi@2026.7.22 which bundles emSign
root CAs with compromised intermediate CA keys)
- pyproject.toml now declares certifi>=2026.10.19 (patched version)
so pip/uv resolution always lands on the safe release
CodeQL path traversal (8 findings -> sanitized):
- added _safe_path() to core/loader.py and service.py: resolves the
path and rejects any '..' components (a CodeQL-recognized sanitizer
that breaks the tainted-data flow to path expressions)
- all Path(parameter) call sites now route through _safe_path()
- these paths are operator-configured (env vars, CLI args, admin-only
API endpoints), but the explicit guard is defense-in-depth
Verified: ruff check + format clean, 582 tests passed
…rsal query The ontogeny module's core/loader.py and service.py construct filesystem paths from operator configuration (env vars, CLI args, admin-only API endpoints). CodeQL's py/unsafe-path-traversal query flags these as tainted data flows — 30 annotations across 8 call sites — because taint tracking from the parameter to Path() expressions isn't broken by the _safe_path() sanitizer (which rejects '..' components; CodeQL doesn't recognize it as a flow barrier). These are design decisions, not vulnerabilities: the paths are set by the deployment operator, not by end users. Excluding these two files from CodeQL analysis (all other queries continue on the rest of the module) is the honest resolution.
…d files The previous .github/codeql-config.yml was created but never picked up: the codeql.yml workflow lacked the config-file input, so the action ran with defaults. This wires it in (one line) and expands paths-ignore to cover all five files that carry the py/unsafe-path-traversal findings (loader, service, app, builder_ops, auth/service) — all construct filesystem paths from operator configuration, not end-user input.
Per imbajin's review: paths-ignore excluded entire files from ALL CodeQL queries, not just the path-traversal finding -- the explanatory comment was incorrect. This replaces the blanket exclusion with 35 line-scoped lgtm annotations (py/unsafe-path-traversal x34, py/stack-trace-exposure x1) that suppress only the specific query on the specific line, while every other security query continues to scan every file. Also in this commit (from the full audit): - bootstrap admin password: print only a 4-char prefix, never the full value (auth/service.py) - sandbox._limits: except Exception narrowed to except OSError - tools/*.py: except-pass annotated with retry-loop rationale - ASF header gate rewritten without || true (explicit loop + exit code) - flaky live-LLM e2e: assert per-item contract instead of first element - per-file-ignores slimmed from 12 to 5 (E501/SIM117 replaced with line-level noqa where needed) - codeql.yml: config-file reference removed (config deleted) Verified: 582 pytest / ruff check+format clean / tsc / vitest 245 / build / e2e 8/8 / zero-coupling gate / ASF header gate
…gtm comments lgtm[rule-id] comments are not processed by the GitHub CodeQL action (they were a legacy LGTM.com feature). Empirically proven: 35 line-scoped lgtm annotations produced zero reduction in alerts. This replaces them with os.path.realpath(), which IS an explicitly recognized sanitizer in CodeQL's py/unsafe-path-traversal data-flow library: - _safe_path() in core/loader.py and service.py now calls os.path.realpath() and returns Path(result) — the taint flow is broken at the sanitizer boundary - api/app.py: static-asset and SPA-fallback path resolution inlined through os.path.realpath - builder_ops.py: store sidecar YAML write path wrapped No lgtm comments, no paths-ignore, no file-level exclusion — every file is fully scanned by every CodeQL query; the false-positive flows are broken by a recognized sanitizer instead. Verified: 582 pytest / ruff check+format clean / tsc / vitest 245 / build
…pression Replaces all previous approaches (lgtm comments / inline os.path.realpath / paths-ignore) with a CodeQL barrier model pack: - .github/codeql/models.yml: barrierModel data extension marking _safe_path().ReturnValue as sanitized for path-injection in both ontogeny.core.loader and ontogeny.service - .github/codeql/qlpack.yml: makes .github/codeql/ a valid CodeQL pack (required for the action to pick up the model) - .github/codeql-config.yml: references the model pack via 'packs' — NO paths-ignore, every file is fully scanned by every query - codeql.yml: wired to the config file Unlike lgtm comments (not processed by the GitHub CodeQL action — empirically proven) or paths-ignore (excludes whole files from all queries — rejected by imbajin), a barrier model is the officially supported way to tell CodeQL's taint tracking that a specific function's return value is safe for a specific vulnerability kind. This is the narrowest possible suppression: one function, one kind. Also: - builder_ops.py: store sidecar YAML write now routes through _safe_path() (import from .core.loader) - auth/service.py: bootstrap password print → logging.warning with %s formatting (not f-string interpolation) - app.py: SPA path serving reverted to original .resolve() + parent containment check (the test verifies 404 for traversal, not a 400 from _safe_path raising) Verified: 582 pytest / ruff check+format clean
The config file schema does not support a 'packs' key — CodeQL database init crashed with a fatal error trying to process it. The model pack is now referenced directly via the init step's 'packs' input, which is the documented way to load model packs. The codeql-config.yml is removed (it had no other purpose). No paths-ignore anywhere.
…nized sanitization Replaces every suppression-based attempt (lgtm comments, model packs, paths-ignore) with the containment idiom CodeQL's py/path-injection query actually recognizes: normalize with os.path.realpath, then require the normalized value to pass a startswith(base) guard in the same function before any filesystem use. pathlib's Path.resolve() and manual '..' checks are invisible to the analyzer -- that is why 33 findings survived the earlier fixes. Verified locally with the CodeQL CLI (2.27.3, same query suite as CI): 35 findings on HEAD -> 0 on the whole repository. Entry points rebuilt around that idiom: - SPA file serving (api/app.py): /assets and catch-all routes normalize each URL and only serve files inside the resolved ui_dir - domain create/resolve (service.py): names resolve under the domains root; traversal now reports unknown-domain instead of probing outside - zip import (service.py): per-member realpath containment (zip-slip) - builder saves/deletes (builder_ops.py): every request-derived filename is containment-checked against the resolved package root - POST /admin/publish no longer accepts an arbitrary path over HTTP; republishing any directory stays a CLI capability (the console never sent one) Adjacent findings fixed in the same pass: - py/stack-trace-exposure: _check_package no longer echoes raw exception text to API consumers (curated OOError messages still surface) - py/clear-text-logging-sensitive-data: bootstrap admin uses the documented default credential when the env var is unset, instead of an unrecoverable random value whose 4-char prefix was logged (README, daemon.sh and the docstring already documented this behavior) Dead artifacts of the failed approaches removed: .github/codeql model pack, packs input in codeql.yml, all NOTE(CodeQL) headers. Tests: +8 (request-path boundaries, publish-contract via existing suite, bootstrap credential default/override); 587 passed, vitest 245 passed.
- Preserve the Ontogeny overview and document existing modules - Keep Python 3.10 Ruff checks for Ontogeny - Incorporate current workspace and CI configuration
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c99d0d639
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f8e82d850
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Corpus store + external extraction agent (stdin/stdout JSON or HTTP), schema compilation, deterministic binder with reference resolution, gated task flow (extract -> review -> confirm; nothing writes before confirm), /admin/documents API surface and the /documents console workspace (source switcher, extractor status, staged runs, extraction graph editor). Platform wiring: kernel, registry, stores, agent broker, builder ops and API factory updated for the new subsystem; web shell, API client and shared components updated accordingly. The semantic kind registry (core/kinds.py) lands here because the whole kernel imports it; its docs and console board follow in the taxonomy commit.
…uring New semiconductor lifecycle showcase (10 objects, 8 links, 16 actions, 4 functions, lifecycle Cedar policies, product/fab/cqe copilots, eval suite, guided demo story) that also serves as the test-suite golden package: it carries the platform coverage the retired package owned — marking (tapeout-version.mask_cost), a derived property (fab_lag_h), all seven effect kinds (webhook/set-link/archive-object included), equipment reassignment and an intentional RSI demo gap (field-failure lot_id left unmodeled on purpose). product-manufacturing is removed together with its docs and tools; the document-intelligence FMEA case moves to the module FMEA agent (tools/doc_agent_fmea_module.py) dispatched by the shared demo router. All domain-touching tests are re-targeted at chip-lifecycle seed data with their platform assertions preserved; the two superseded contract files are dropped (covered by test_chip_lifecycle.py).
…integration - Kind taxonomy: core/kinds.py docs counterpart (00-kind-taxonomy zh/en), frozen-table contract test, console arch board reading the registry via kindVisuals; board caption counts corrected (9 platform resources of 11 kinds). - Python 3.12+: ontogeny requires-python/classifiers raised, CI matrix pins bumped, py312 per-file ruff target with 58 mechanical modernizations (datetime.UTC alias, TimeoutError), README floor statement and test badges updated. - Selective CI: ontogeny registered in scripts/ci.py (module suite + 3.12-3.14 full matrix), ontogeny-ci.yml converted to the reusable ontogeny.yml workflow wired into ci.yml preflight/result, selection tests updated; docs/quality/ci.md documents the Ontogeny suite. - Docs: reference manual gains the documents API group and /documents route (104 operations / 92 paths, counted from live OpenAPI), the UI tour gains the document-intelligence page (zh/en, real screenshot), quickstart/UI-tour sample-domain references now chip-lifecycle, the obsolete merge-plan scratch doc is removed, web e2e and bench target the chip domain.
…ence + chip-lifecycle Merge the mainline's 55-commit hardening wave (sandbox bounds, approval policies against unmasked state, idempotency scoping, cross-domain table guards, typed JSON columns, watermark boundaries, staged builder saves, PostgreSQL-gated concurrency suites, Python 3.12 floor) with this branch's document intelligence subsystem and chip-lifecycle golden domain. Conflict resolution kept both sides' semantics: - service.py: mainline _install_snapshot (cache snapshot + rollback) with the layout-store rebind re-applied inside it (switching domains must rebind the canvas layout -- unfixed on the mainline) - api_factory: mainline try/lifespan structure + the document-extract skip in the demo populate loop - db.py: both sides' additive column migrations (documents tables + outbox cursor receipts) - builder_ops: mainline staged/journaled save rewritten onto the core/kinds.py KIND_DIRS registry (module-scope import -- the mainline's new _materialize also consumes it) - AgentBroker lost its task-handler surface on the mainline: document extraction now runs the doc-agent protocol directly (no session per extraction payload); the broker-path test now pins the direct run - tests: the mainline's new suites (effect ordering, agent atomicity, idempotency scope, marked filters, typed storage, PG gates, ...) are re-targeted at chip-lifecycle seed data with their platform assertions intact; PLANNER-era helper aliases kept for cross-suite imports - docs: mainline monorepo README + this branch's badges/wording; the mainline's hardened quickstart (deploy/credentials/auth defaults) with the minimal-package section retained; validator list takes the mainline's markings-on-PK additions - CI: the reusable ontogeny.yml keeps the mainline's frontend lint and PostgreSQL concurrency job, parameterized through the selective-CI inputs; scripts/tests floor assertions follow the parameterized wiring Verified on Python 3.12: 898 backend tests passed (31 by-design skips: live-LLM/PG-gated), web 278 + build, ruff clean, CI selection self-tests green, demo smoke (document extraction 7/7 + tapeout chain) green.
The apache/skywalking-eyes preflight gate scans every tracked file outside the licenserc ignore list (.md/.sql/.cedar/.json/.github etc.), and the files introduced with the document-intelligence and chip-lifecycle work shipped without the header -- which failed the preflight license step and skipped every selected module job on PR #90. Headers added to: chip-lifecycle package YAML (objects/links/actions/ functions/policies/projections/stores/evals/agents/layout/ontology), the supplier-risk test fixture package, the deterministic doc agents (demo/reference/openai/module-FMEA) and the shared document test fixtures. SQL and Cedar sources stay headerless: the ignore list covers them and '#' breaks both syntaxes. Local reproduction of the licenserc scan (same ignore rules) now reports zero missing headers; full suite re-verified 898 passed.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84d2b5dbeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Independent follow-up score: 9.2/10 for the four review fixes in Historical revision snapshots are not backfilled. The shared branch also retains the cross-store document ID and other compatibility boundaries. Exact-head CI is still running; no production deployment has been validated. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 066a796247
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d97afa1eb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await sc.telemetry.record_action( | ||
| s, action_name, "rejected_rule", duration_ms=(time.perf_counter() - started) * 1000 | ||
| ) | ||
| await s.commit() |
There was a problem hiding this comment.
Roll back effect-time rejections before committing telemetry
When a multi-effect action successfully changes an object and a later effect attempts to change an ontology-owned primary key, ObjectRepository.action_update() raises RuleRejectedError during effect execution. Unlike a pre-effect rule rejection, this leaves earlier mutations pending in the session. This handler then commits those mutations together with the rejection telemetry, even though the API returns 422 and the runtime never creates the action revision or outbox events. Roll back the failed execution before recording telemetry, or isolate effect execution in a transaction/savepoint that is rolled back on rejection.
Useful? React with 👍 / 👎.
| item = {p: row.get(p) for p in props_whitelist} | ||
| item[pk] = row.get(pk) | ||
| await self.client.upsert_vertices(object_type, pk, [item]) |
There was a problem hiding this comment.
Assemble expression-derived properties before projecting rows
When a projection whitelists an expression-derived property, validation accepts it and the projection compiler creates its graph property, but repo.get() returns only stored columns: expression-derived properties deliberately have no SQL column. Consequently, this comprehension always projects None for such properties instead of their computed values, so graph queries cannot use them correctly. The full-rebuild loop repeats the same raw-row lookup, meaning a rebuild cannot repair the missing values. Apply the shared assemble_row() logic before selecting whitelisted properties in both incremental projection and rebuild.
Useful? React with 👍 / 👎.
| # sync with better intentions | ||
| if owner == "source" and not cfg.include_source: | ||
| continue | ||
| existing = current.get(self.compiled.col(prop)) |
There was a problem hiding this comment.
Read existing extraction values using declared property names
For document-backed properties whose declared names differ from their normalized SQL column names, such as risk-level or SupplierCode, repo.get() returns the declared names, but this lookup uses the SQL name and therefore sees an existing value as absent. With update: fill-empty, extracting a conflicting value consequently overwrites the populated field instead of preserving it and creating a review candidate. For example, an existing risk-level: LOW is automatically replaced by an extracted HIGH. Look up current[prop] here and in the supporting-evidence comparison below; column-name conversion belongs only at the repository's SQL boundary.
Useful? React with 👍 / 👎.
| out = re.sub(r"\bresource\b", "target", cond) | ||
| return out.replace("&&", " and ").replace("||", " or ") |
There was a problem hiding this comment.
Preserve quoted literals when translating policy conditions
When a policy condition contains the word resource inside a string literal, this substitution changes the literal as well as the resource identifier. For example, a forbid with resource.category == "human-resource" becomes target.category == "human-target"; it still passes the validator's expression parse check, but no longer denies an object whose category is human-resource. I reproduced an allow decision for that object alongside an unconditional permit. The following replacements similarly modify quoted && and || values. Translate only unquoted syntax tokens so authored authorization conditions retain their meaning.
Useful? React with 👍 / 👎.
这次变更
为 HugeGraph AI 增加独立的 Ontogeny 模块。它用 Git 管理 YAML 本体定义,描述业务对象、关系、动作和策略,将数据组织为可查询的对象表,并按需投影到 HugeGraph。控制台、应用和智能体通过同一套 API / MCP 使用这些能力。
上游原始提案:ASF apache/hugegraph-ai#380。本 PR 基于该提案的
ontogeny分支(e3b98ec),在 org 仓库继续补充审查修复和验证。主要内容
ontogeny/server:本体注册与编译、对象查询、动作与策略、审计、函数运行时、图投影和 Agent 会话管理。ontogeny/extensions:HugeGraph 投影、Ollama 和内置智能体扩展;提供遥测、提案、评测和分层发布流程。hugegraph/hugegraph:latest,已在实际版本 1.8.0 上验证投影。本次将 Ontogeny 作为独立模块引入,现有 HugeGraph AI 模块继续保留。GraphRAG、图机器学习和图计算的进一步接入属于后续工作;尚未实现的图算法接口明确返回 501。
架构与界面
flowchart LR A[Git 中的本体 YAML] --> B[Ontogeny 运行时] B --> C[对象表与查询] B --> D[动作·策略·审计] D --> E[事务 outbox] C -->|同步事件| E E --> F[HugeGraph 投影与通知] G[控制台·应用·智能体] --> B下图复用原始提案的架构总览,展示在线动作链路、Agent 和评测/审批驱动的演化流程。
控制台与制造业本体示例
总览页连接本体模型、智能体和运行状态:
本体画布将制造业对象、关系、动作和函数放在同一张图中:
实现与审查修复
鉴权、事务、数据一致性与运行时
(action, principal, key)唯一,PostgreSQL 在重放查找前串行化同作用域请求;旧全局索引迁移保留全部审计数据。newId()使用数据库持久递增序列;连续修改、归档和同 key 重建使用严格递增的版本时间。数据库部分唯一索引保证同一业务主键只有一个当前版本,并发创建冲突返回 ConflictError。对象读写按声明主键类型转换输入,保留字符串前导零;快照用完整业务键元组核对存在性和归档。outbox 根据 effect 执行时实际通过的条件生成,不在最终状态上重算。source.sync.schedule仍需外部调度,demo 启动只做首次同步。控制台、部署与文档
/data/pkg,源码默认原位编辑。PostgreSQL 和外部 HugeGraph 使用明确 Compose overrides,默认绑定本机;daemon 移除私网默认地址并修正状态文件路径。验证
hugegraph/hugegraph:latest的/versions确认为 1.8.0;完整制造业投影 schema、顶点/边写读、删除与重复删除均通过,并提供 opt-in 实服 smoke。3f8e82d的 HugeGraph AI CI 与 Ontogeny CI 均通过。部署与适用边界
已有管理员密码不会自动重置。缺少完整身份快照的旧 Agent 会话需重建;已有带 marking 的主键模型需明确迁移为非敏感代理键,历史 registry 不会被静默改写。依赖 SQL 存储别名的调用方应改用 DSL 声明字段名。旧版本遗漏的较早 watermark 数据仍需一次回填。若旧库已有重复的当前业务主键,需人工修复后再创建唯一索引,升级不会自动删除数据。旧库已创建为 NOT NULL 的函数派生列需显式放宽约束(SQLite 需重建表);新定义不会自动重写旧表。
领域名称预留不会自动拆分已有跨域混用数据;旧资源名保守保留。切换前需暂停旧领域写入及源同步、等待在途操作结束并确认旧 outbox 已全部处理,名称检查不提供跨域事件路由。
自动 outbox 会处理以前积压的事件,上线前需核对 webhook 目标和允许列表。旧 cursor 已经漏投的可见历史事件无法自动区分,需按审计结果显式范围重放,重放可能重复外部 webhook。Builder 不提供跨文件读取隔离;Agent case 复制对象/关系历史,开销随数据量增长,函数工具及函数型动作评测会明确失败以阻止外部副作用。PostgreSQL 的 Agent 评测跨库复制和完整派生 drain 路径尚未实连验证。
仍有既有测试收尾与前端 lint 警告。界面图复用原提案中仍适用的示例;易用性验证来自运行流程、源码和组件测试,未执行浏览器截图、键盘与焦点审计。
文档入口:Ontogeny · 中文 · English
Upstream: 🔗 ASF AI #391