Skip to content

[Deepspeed] skip device mesh creation when deepspeed and sp_size >1 - #3914

Merged
SunMarc merged 1 commit into
huggingface:mainfrom
kashif:deepspeed_mesh
Jan 27, 2026
Merged

[Deepspeed] skip device mesh creation when deepspeed and sp_size >1#3914
SunMarc merged 1 commit into
huggingface:mainfrom
kashif:deepspeed_mesh

Conversation

@kashif

@kashif kashif commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Accelerate should skip DeviceMesh creation when sp_backend == "deepspeed" because DeepSpeed handles all SP groups internally through UlyssesSPAttentionHF.register_with_transformers().

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@kashif
kashif requested a review from SunMarc January 27, 2026 09:54
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SunMarc
SunMarc merged commit 08e212a into huggingface:main Jan 27, 2026
16 of 25 checks passed
@kashif
kashif deleted the deepspeed_mesh branch January 27, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants