feat: allow json_schema in response format and add test#3276
Open
feat: allow json_schema in response format and add test#3276
Conversation
Narsil
reviewed
Jun 26, 2025
Contributor
Narsil
left a comment
There was a problem hiding this comment.
Can you find a way to remove ALL serde(untagged), and have simpler hierarchy ?
I feel like unit tests with valid schemas and how we expect to parse them should exist in here.
router/src/lib.rs
Outdated
Comment on lines
263
to
264
| JsonSchema { json_schema: JsonSchemaOrConfig }, | ||
| Value { value: JsonSchemaOrConfig }, |
Contributor
There was a problem hiding this comment.
This seems like we just want serde(alias="value") if I read correctly.
router/src/lib.rs
Outdated
Comment on lines
268
to
272
| #[cfg_attr(test, derive(PartialEq))] | ||
| #[serde(untagged)] | ||
| pub enum JsonSchemaOrConfig { | ||
| Config(JsonSchemaConfig), | ||
| Value(serde_json::Value), |
Contributor
There was a problem hiding this comment.
This is extremely fishy. untagged + recursive descent seems like a great way to shoot ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the
response_format.type = "json_schema"to allow the schema to be specified with the keyvalueorjson_schema, prior to these changes only thevaluekey would be allowed.These changes enable the two following request to succeed: