Skip to content

Safe import of LRScheduler#29919

Merged
amyeroberts merged 4 commits intohuggingface:mainfrom
amyeroberts:safe-lrscheduler-import
Mar 28, 2024
Merged

Safe import of LRScheduler#29919
amyeroberts merged 4 commits intohuggingface:mainfrom
amyeroberts:safe-lrscheduler-import

Conversation

@amyeroberts
Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts commented Mar 27, 2024

What does this PR do?

Fixes #29895

cc @ArthurZucker

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

@xkszltl xkszltl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge these 2 is_torch_available sections?

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix

amyeroberts and others added 3 commits March 28, 2024 08:46
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
@amyeroberts amyeroberts merged commit 855b95c into huggingface:main Mar 28, 2024
@amyeroberts amyeroberts deleted the safe-lrscheduler-import branch March 28, 2024 09:54
amyeroberts added a commit that referenced this pull request Mar 28, 2024
* Safe import of LRScheduler

* Update src/transformers/trainer_pt_utils.py

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>

* Update src/transformers/trainer_pt_utils.py

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>

* Fix up

---------

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transformers 4.39.0 has breaking change on torch compatibility.

4 participants