Conversation
muellerzr
left a comment
There was a problem hiding this comment.
Nice! Seems handy. Could you rebase from main and see if that fixes the failing tests?
b8e64ec to
e8eadd2
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Looks like it fixed some tests but not all. |
muellerzr
left a comment
There was a problem hiding this comment.
LG2M, no idea why that pytorch test is failing 😕
cc @amyeroberts for final review (and ideas(?) was seeing that on another PR of mine iirc)
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this!
|
@visheratin CI should be green on rebase, we found the issue :) |
e8eadd2 to
ee9f3c3
Compare
|
@muellerzr a couple of tests are still failing. |
|
@visheratin Looks like they were failing because of connection issues with the hub. I've re-run - which should hopefully resolve |
What does this PR do?
This PR adds the Warmup-Stable-Decay learning rate scheduler. The scheduler and its benefits are described in detail in the MiniCPM blog post. In short, it allows continuous training and performs better than standard cosine scheduler.
Here is an example of learning rate dynamics with this schedule:

Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr, @pacman100