[cleanup] Remove deprecated load config from file#42383
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: metaclip_2 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
This PR is ready for review. CI is failing on which looks unrelated to the PR. I already retriggered the CI once but it didn't help. |
LysandreJik
approved these changes
Nov 27, 2025
LysandreJik
left a comment
Member
There was a problem hiding this comment.
Really satisfying PR, thanks for handling this @Wauplin!
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Remove deprecated load config from file * code quality * ruff * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the possibility to load a Config using a file URL directly. This is a deprecated feature expected to be removed in transformers v5:
I've also removed the legacy test
test_legacy_load_from_one_filetesting this feature.In addition, this allowed me to cleanup the
is_remote_urlanddownload_urlhelpers and to entirely avoid importinghttp_getfromhuggingface_hub(which is to be considered a "semi-private" helper. I have refactored a few tests using it to default tohf_hub_downloadinstead.