Continuous Batching support for AsyncGRPO#5781
Draft
qgallouedec wants to merge 1 commit into
Draft
Conversation
Open
8 tasks
Member
sergiopaniego
left a comment
sergiopaniego
left a comment
There was a problem hiding this comment.
small pass
it'd nice to have an example script + update the docs for the new feature.
| > Parameters that control the rollout backend | ||
|
|
||
| backend (`str`, *optional*, defaults to `"vllm"`): | ||
| Generation backend. One of `"vllm"` (use an external vLLM server, default) or `"cb"` (use |
Member
There was a problem hiding this comment.
backend param needs a validation check ("vllm", "cb")
| # Use the injected worker (e.g. a stub in tests). The queue is owned by the worker. | ||
| self.rollout_worker = rollout_worker | ||
| elif self.args.backend == "cb": | ||
| from .cb_rollout_worker import CBRolloutWorker |
Member
There was a problem hiding this comment.
cb_rollout_worker.py missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.