let unflatten iterate over sorted object keys#44
Merged
timoxley merged 2 commits intohughsk:masterfrom Jul 25, 2017
Merged
Conversation
Contributor
Author
|
@hughsk ping. this is serious i think. |
Contributor
Author
| } else { | ||
| return 0 | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
Note you can just return keyA.length - keyB.length
Contributor
Author
There was a problem hiding this comment.
oh yeah that's much better! thanks
|
IMO the default lexicographic sort is better than length since it gives each key a consistent placement while still ensuring that nested keys come after the respective parent key. Not sure if the quibble is even necessary since this repo seems inactive. |
|
Is this the breaking change from 4.0.0 ? b6633d0 PS: "this repo seems inactive"? |
Contributor
|
@yvele Correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #43
sorting the object keys by length ensures that lower level objects are created first.
without this PR an empty object is created (and never replaced/extended later) thus dropping parts of the object tree.