ESLint Enforce semicolons#169
Merged
Merged
Conversation
mikeselander
approved these changes
Jan 2, 2020
mikeselander
left a comment
mikeselander
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍 thank you for pushing this through.
Contributor
|
As a note, we should update the Handbook in tandem with this change. |
ntwb
approved these changes
Jan 2, 2020
sambulance
reviewed
Jan 6, 2020
| // Missing semicolon. | ||
| const testMissingSemicolon = 'foo' | ||
|
|
||
| // Missing semicolon. |
Member
There was a problem hiding this comment.
The semicolon isn't missing here, just spaced incorrectly.
Member
Author
There was a problem hiding this comment.
Oh thanks Sam - I'll update the comment
rmccue
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce semicolons.
Closes #153