Repository navigation
feat(RadioGroup): add autocomplete prop and disable browser autofill on the hidden input - #2198
Merged
huntabyte merged 6 commits intoOct 20, 2026
Conversation
🦋 Changeset detectedLatest commit: 369a439 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
anastasiia-baboshina
marked this pull request as ready for review
October 12, 2026 12:28
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2152.
Problem
RadioGroup.Rootrenders a hidden text input whennameis set. In a form with fields that the browser autofills (name, email, ...), Chrome can also fill this hidden input with a random string that doesn't match any radio item, and the user can't see it because the visible selection doesn't change.Change
autocompleteprop toRadioGroup.Rootthat is forwarded to the hidden input (same approach asSelect.Root, see Pass props to Select's hidden input (or add autocomplete option) #1543 / feat(Select): exposeautocompleteattribute onSelect.Root#1547)."off", since there is no case where a browser should autofill the hidden input of a radio group. Passing another value (for example"one-time-code") overrides it.Tests
Added two browser tests: the hidden input has
autocomplete="off"by default, and the prop is forwarded when set. Ran the RadioGroup browser suite in Chromium: 34 passed; without the source change the two new tests fail.prettier,oxlint,eslintandsvelte-check(bits-ui package) are clean. WebKit and the docs type check were not run locally.Question
Select.Rootforwardsautocompletewith no default, while here I made it default tooffas the issue suggests. If you'd rather keep the defaultundefinedand only expose the prop, it's a one-line change.This PR was prepared with the help of Claude Code. The issue was reproduced from the report and the result checked locally.