Repository navigation
fix(Tooltip): close when any scrolling ancestor of the trigger scrolls - #2206
Merged
huntabyte merged 1 commit intoOct 20, 2026
Merged
Conversation
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2205.
An element's
scrollevent does not bubble (CSSOM View: only a Document's scroll is fired "that bubbles"), so the provider'swindowlistener heard document scrolls only and never closed a tooltip whose trigger sits in a scrolling element. It now listens in the capture phase (passive), so the existingtarget.contains(triggerNode)check sees element scrolls too. Document scrolls behave as before.The scroll test dispatched a bubbling
scrollon an element, which a browser never does, so it passed without covering element scrolls. It now dispatches the event as the browser does.Verification, on
main(fd10616):tooltip.browser.test.tspasses in both engines with the fix. One WebKit leg ("provider: should not re-enable delay while switching between tooltips") timed out once in a loaded full-file run and passed on every re-run, with and without this change.mainhere, and they differ from run to run.svelte-check(bits-ui), prettier, oxlint and eslint are clean. The changeset is a patch.