Repository navigation
fix(Select): highlight the selected item on open when its value is "" - #2213
Merged
Merged
Conversation
- Look up the selected item even when its value is an empty string, in single and multiple selects - Allow Enter to select a highlighted empty-value item in Combobox - Add browser tests covering Select, multiple Select and Combobox (#1858)
🦋 Changeset detectedLatest commit: d451f68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
- move the empty-value Select reopen and multiple tests into select.browser.test.ts - move the empty-value Enter selection test into combobox.browser.test.ts - remove the standalone select-empty-value.browser.test.ts
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selectwhose selected item has an empty string value (e.g. an "All" option) now highlights that item instead of falling back to the first item.SelectSingleRootStateandSelectMultipleRootStateno longer skip the selected-node lookup when the value is"". If no item matches, they still fall back to the first candidate.Combobox: the Enter key handler now checkshighlightedValue !== nullinstead of truthiness, so a highlighted""item can be selected with Enter.bits-ui.Testing
select-empty-value.browser.test.ts. It covers the following cases:Select, with and without a viewport, with the empty item first and last. It selects the empty item, reopens, and checks the item is highlighted and selected, and that arrow-key navigation still works.Selectwithvalue: [""]highlights the empty item on open.Comboboxselects a highlighted empty value item with Enter, and the item is highlighted and selected on reopen.