Repository navigation
fix(NavigationMenu): only register layers for open force-mounted content - #2218
Merged
Merged
Conversation
- Enable DismissibleLayer and EscapeLayer only while the content's item is open - Stop closed force-mounted content from closing the open item on inside clicks or stealing escape focus - Expose `open` on NavigationMenuContentImplState and reuse it for `data-state` - Add browser tests and a changeset
🦋 Changeset detectedLatest commit: 886e0be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigationMenu.Contentnow enables itsDismissibleLayerandEscapeLayeronly while its item is open, instead of always (enabled={true}).forceMount, closed contents kept their layers registered. Clicking inside the open item's content counted as an outside interaction for the other contents, which closed the open item (withopenOnHover={false}). Closed contents could also take over escape handling, so focus didn't return to the trigger.openderived value toNavigationMenuContentImplState. The layerenabledprops anddata-stateboth use it.openOnHoverandforceMountprops #2034.Testing
navigation-menu.browser.test.ts, using a newnavigation-menu-force-mount-test.sveltefixture:openOnHover={false}.