Repository navigation
fix(FocusScope): keep focus on inputs in a nested open shadow root - #2223
Merged
Merged
Conversation
- retarget focus targets to the scope's tree so shadow hosts resolve inside the container - stop treating focus in a nested web component as escaping the trap - add Dialog tests and a changeset
🦋 Changeset detectedLatest commit: c8bc7b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FocusScope(e.g. a web component's<input>) was treated as focus escaping the trap, so focus was pulled back out.retargetToScopeTree, which climbs shadow hosts so a node in a nested shadow root resolves to its host in the scope's tree before thecontainer.containscheck.focusinhandler and in the deferred open auto-focus check, so anonOpenAutoFocusthat focuses a shadow input is no longer overridden.nulland are still treated as outside the scope.bits-ui.Testing
Dialog.Content, and typing reaches it.onOpenAutoFocusfocusing a shadow input isn't stolen by the deferred auto-focus frame.