Repository navigation
fix(DismissibleLayer): close layers on rapid outside pointerdowns (#1743) - #2229
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b4dd68f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContextMenutriggers left earlier menus open.pointerdownlanding within the 10ms dismissal debounce replaced the pending one, so it was judged against the newly opened layer and the earlier layer never closed.DismissibleLayerStatenow flushes the pending outside-interaction handler in thepointerdowncapture phase, before the new event's state is marked, so each interaction is settled before the next begins.debouncegains aflush()method that runs the pending call immediately (once), anddestroy()now also clears the pending args.Testing
debounceunit test:flushis a no-op with nothing pending, runs the latest pending call exactly once, and doesn't re-fire after the timer would have elapsed.ContextMenubrowser test (context-menu-rapid-test.svelte): 20 rapid right clicks across 30 triggers leave only the last menu open.