PoC: tx history using events by meiersi-da · Pull Request #4638 · hyperledger-labs/splice

meiersi-da · 2026-03-25T07:47:17Z

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

CMD: gsr -f -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' 'token-standard-test(?!-v)///token-standard-test-v1'

…1/ -> token-standard/splice-api-token-transfer-instruction-v2/ CMD: rsync -a token-standard/splice-api-token-transfer-instruction-v1/ token-standard/splice-api-token-transfer-instruction-v2/

…-standard/splice-token-standard-test-v2/ CMD: rsync -a token-standard/splice-token-standard-test-v1/ token-standard/splice-token-standard-test-v2/

… -> token-standard/splice-api-token-allocation-request-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-request-v1/ token-standard/splice-api-token-allocation-request-v2/

…-v1/ -> token-standard/splice-api-token-allocation-instruction-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-instruction-v1/ token-standard/splice-api-token-allocation-instruction-v2/

…n-standard/splice-api-token-allocation-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-v1/ token-standard/splice-api-token-allocation-v2/

…tandard/splice-api-token-holding-v2/ CMD: rsync -a token-standard/splice-api-token-holding-v1/ token-standard/splice-api-token-holding-v2/

…daml/Splice/Testing/Apps/TradingApp.daml -> token-standard/splice-token-standard-test-v2/daml/Splice/Testing/Apps/TradingAppV2.daml CMD: rsync -a token-standard/examples/splice-token-test-trading-app/daml/Splice/Testing/Apps/TradingApp.daml token-standard/splice-token-standard-test-v2/daml/Splice/Testing/Apps/TradingAppV2.daml

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<![Mm]etadata-)(?<![Mm]etadata/)(?<![Mm]etadata)(?<! )v1///v2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<![Mm]etadata-)(?<![Mm]etadata/)(?<![Mm]etadata)(?<! )V1///V2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<=[./])AmuletRegistry(?!V2)///AmuletRegistryV2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<=[./])RegistryApi(?!V2)///RegistryApiV2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<=[./])WalletClient(?!V2)///WalletClientV2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<!TokenApi)(?<=[./])Utils(?!V2)///UtilsV2'

CMD: gsr -f -i 'token-standard/*-v2/*' -e 'scripts/rename.sh' -e '**/release_notes.rst' -e '**/auth0.ts' -e 'token-standard/README.md' -e 'token-standard/CHANGELOG.md' -e '*.lock' -e 'nix/**' -e '*lock.json' -e '**/expected*.json' -e 'canton/**' '(?<=[./])TradingApp(?!V2)///TradingAppV2'

Make PoC compile after rebase tests pass! *yay* Reuse Lock and InstrumentId from V1 Add type-class based conversion Communicate action graph in transfer instr partial work towards v1 transfer Base Amulet implementation changes on V1 Add conversion of instrumentId and lock make tests pass and polish conversion utilities Use V1 views as the base impl. for Amulet Switch to multiple actors on transfer instructions Split AmuletAllocation and AmuletAllocationV2 Remove accidentally committed file external amulet rules with inline two-step tfer Revert "external amulet rules with inline two-step tfer" This reverts commit 0af6c68. Switch to a list of parties for the executors switch allocationfactory to actors partial work towards V1/V2 alloc compatibility partial implemenation of V2 on AmuletAllocation Move settlement implementation into generic utils write generic mixed version settlement algorithm Allow V2 settlemnt of V1 allocations partial testing of mixed settlement Wrangle mixed version settlement into submissions ... but its not pretty :/ script allocation request acceptance Introdue settlementVersion and settlementV1Authorizers Move authorizer into allocation specification Switch back to single executor; remove tryDowncast_allocation Ensure V2 settlement of V1 allocation always calls V1 choices Implement AmuletAllocationV1's V2 withdraw Draft impl. of V1-based V2-alloc-cancel impl Polish comments and types on allocation interface PARTIAL work towards allocation factory polish Move and polish SettlementFactory_SettleBatch Remove HoldingMap, group settle result holdings by account Split UtilsV2 into better scoped modules Share public fetch implementations Better structure and comments for defaultBatchSettleImpl Use controllersOverride pattern for settleBatch Add more actor checks and self-archivals Better names for default allocation implementations self-review More self-review; polish AmuletAllocationV2 impl. More allocation impl polish Polish TradingAppV2 - step 1 Polish TradingApp: reuse AllocationRequestView Polish test code Generalize and simplify V1 compatibility code Remove canWithdraw and default choice controllers infra Adjust allocation commentary to polish Self-review Add missing tx metadata for history parsing Remove expectedAdmin as it is redundant Switch to multiple actors for publicFetch Add CHANGELOG for preview branch Reintroduce senderHoldingCids where more clear Multiple executors -- pure rename Switch to multiple executors Rename 'Splice.Api.Token.UtilsV2' to 'Splice.TokenStandard.Utils' Rename 'splice-api-token-utils-v2' to 'splice-token-standard-utils' cleanup allocation request API -- missing impl. Default implementations for AllocationRequest + TradingAppV2 cleanup Undo changes to TradingAppV1 Improve authorization flow for TradingAppV2 Improve trade settlement test script Make cancellation work with on-demand authorization Save partial state Build proper settlement testing infrastructure add support for v1 allocation request acceptance Make tests pass and update some comments More tests and explicit authorizers for allocation requests Improve auto receipt authorizer support in TradingAppV2 Share code for allocation validation Cleanup organization of TokenStandard.Utils and add extra validation for AllocationV2: no account meta Mark internal modules of Utils as internal Cleanup allocations util Comments on internal utils modules Cleanup requirement checking infra Cleanup actors patter infra before fixing all require occurrences Re-export 'TokenStandard.Utils.require' in Splice.Utils Drop superfluous old DvP v2 test Replace FIXMEs by appropriate TODOs Resolve all FIXMEs to resolve before preview Adjust Changelog Self-review of Changelog

Signed-off-by: Simon Meier <simon@digitalasset.com>

[ci] Signed-off-by: Simon Meier <simon@digitalasset.com>

Signed-off-by: Simon Meier <simon@digitalasset.com>

This reverts commit 9dc96ea. Signed-off-by: Simon Meier <simon@digitalasset.com>

Signed-off-by: Simon Meier <simon@digitalasset.com>

bame-da · 2026-03-25T10:27:25Z

daml/splice-amulet/daml/Splice/AmuletAllocationV2.daml

-          let reason = "Settle net negative allocation for settlement " <> show allocation.settlement.settlementRef
          pure V2.Allocation_SettleResult with
            authorizerHoldingCids = mempty
-            meta = simpleHoldingTxMeta TxKind_Burn (Some reason) None


Why are you removing these? Wouldn't they keep some V1 compatibility?

Oh, I see, because it's now in the Events.

meiersi-da added 30 commits March 20, 2026 15:21

Script creating token standard v2 base branch

7f9a33a

add v2 build.sbt

95b4d73

Remove legacy .dependsOn(canton-bindings-java)

3d6020f

copy template: token-standard/splice-api-token-transfer-instruction-v…

f204b51

…1/ -> token-standard/splice-api-token-transfer-instruction-v2/ CMD: rsync -a token-standard/splice-api-token-transfer-instruction-v1/ token-standard/splice-api-token-transfer-instruction-v2/

copy template: token-standard/splice-token-standard-test-v1/ -> token…

55b238f

…-standard/splice-token-standard-test-v2/ CMD: rsync -a token-standard/splice-token-standard-test-v1/ token-standard/splice-token-standard-test-v2/

copy template: token-standard/splice-api-token-allocation-request-v1/…

87a838c

… -> token-standard/splice-api-token-allocation-request-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-request-v1/ token-standard/splice-api-token-allocation-request-v2/

copy template: token-standard/splice-api-token-allocation-instruction…

b3c047c

…-v1/ -> token-standard/splice-api-token-allocation-instruction-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-instruction-v1/ token-standard/splice-api-token-allocation-instruction-v2/

copy template: token-standard/splice-api-token-allocation-v1/ -> toke…

f33105d

…n-standard/splice-api-token-allocation-v2/ CMD: rsync -a token-standard/splice-api-token-allocation-v1/ token-standard/splice-api-token-allocation-v2/

copy template: token-standard/splice-api-token-holding-v1/ -> token-s…

bc59ebf

…tandard/splice-api-token-holding-v2/ CMD: rsync -a token-standard/splice-api-token-holding-v1/ token-standard/splice-api-token-holding-v2/

Add clear call to action for v2 validation

3b6b86e

Signed-off-by: Simon Meier <simon@digitalasset.com>

Build .dars

3cbc29d

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add doc templates

1d14fc3

Signed-off-by: Simon Meier <simon@digitalasset.com>

Fix docs comments that broke docs build

9f70bd4

Signed-off-by: Simon Meier <simon@digitalasset.com>

fix Daml file linting checks

2bc082c

Signed-off-by: Simon Meier <simon@digitalasset.com>

update dars lock

d42551b

Signed-off-by: Simon Meier <simon@digitalasset.com>

Update dar resources

a0b3512

[ci] Signed-off-by: Simon Meier <simon@digitalasset.com>

Make interface call check pass

85e819c

Signed-off-by: Simon Meier <simon@digitalasset.com>

Check and fix ExtraObservers calling convention

742d5c6

Signed-off-by: Simon Meier <simon@digitalasset.com>

Revert "Re-export 'TokenStandard.Utils.require' in Splice.Utils"

b2a1dc0

This reverts commit 9dc96ea. Signed-off-by: Simon Meier <simon@digitalasset.com>

Undo version bump on splice-utils [ci]

13a5e67

Signed-off-by: Simon Meier <simon@digitalasset.com>

meiersi-da added 24 commits March 23, 2026 15:38

Ignore warning from daml test

48e118c

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add comments from reviewing CIP draft text

39ad349

Signed-off-by: Simon Meier <simon@digitalasset.com>

Make bundle working [ci]

c376488

Signed-off-by: Simon Meier <simon@digitalasset.com>

Finish available actions and extra choice observers

90007fd

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add comment wrt limit of transfer offer duration.

e078d37

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add a minimal entry to release notes

ef32b5c

Signed-off-by: Simon Meier <simon@digitalasset.com>

Switch to dedicate result types for allocation requests

4f717cd

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add comments and tighten validation of V2 settlementinfo

33bc560

Signed-off-by: Simon Meier <simon@digitalasset.com>

Align naming of all default implementations

bba1e43

Signed-off-by: Simon Meier <simon@digitalasset.com>

Adjust copyright for new APIs

a122f29

Signed-off-by: Simon Meier <simon@digitalasset.com>

Additional polish from Moritz' review

b038fac

Signed-off-by: Simon Meier <simon@digitalasset.com>

No defaulting for actors in transfer instructions

e81c8f4

Signed-off-by: Simon Meier <simon@digitalasset.com>

Better naming for default impls. for transfer instruction v2

9b02f1c

Signed-off-by: Simon Meier <simon@digitalasset.com>

Update FIXMEs

87cd196

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add test for expired lock

fbfd18b

Signed-off-by: Simon Meier <simon@digitalasset.com>

Rename 'V2.senderHoldingCids' -> 'V2.authorizerHoldingCids'

e90092a

Signed-off-by: Simon Meier <simon@digitalasset.com>

Fix off-ledger APIs

bfcc6ff

Signed-off-by: Simon Meier <simon@digitalasset.com>

Fix doc comments

fa95f13

Signed-off-by: Simon Meier <simon@digitalasset.com>

Dars lock [ci]

82a149f

Signed-off-by: Simon Meier <simon@digitalasset.com>

Self-review [ci]

07093e0

Signed-off-by: Simon Meier <simon@digitalasset.com>

Introduce stub interface for events

ee2c918

Signed-off-by: Simon Meier <simon@digitalasset.com>

Wire up mint, burn, transfer (except for settlement)

caa8a5a

Signed-off-by: Simon Meier <simon@digitalasset.com>

Create Mint events for rewards

0565341

Signed-off-by: Simon Meier <simon@digitalasset.com>

Add events for settle

49f587d

Signed-off-by: Simon Meier <simon@digitalasset.com>

bame-da reviewed Mar 25, 2026

View reviewed changes

meiersi-da force-pushed the meiersi/ts2/preview branch 4 times, most recently from 3e54fb6 to 8a416a0 Compare March 27, 2026 12:26

Base automatically changed from meiersi/ts2/preview to token-standard-v2-upcoming March 27, 2026 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PoC: tx history using events #4638

PoC: tx history using events #4638
meiersi-da wants to merge 56 commits intotoken-standard-v2-upcomingfrom
meiersi/ts2/poc-event-history

meiersi-da commented Mar 25, 2026

Uh oh!

bame-da Mar 25, 2026

Uh oh!

bame-da Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

meiersi-da commented Mar 25, 2026

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

bame-da Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

bame-da Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants