-
Notifications
You must be signed in to change notification settings - Fork 355
Feature: cache clean up #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7aa5b39
Observe notifications
vadymmarkov c32de92
Clear front storage
vadymmarkov f958ec9
Add cleared expired method
vadymmarkov 3e03498
Implement clear expired in memory cache
vadymmarkov 9cb3993
Clear if expired
vadymmarkov 366f796
Handle notifications
vadymmarkov a9f8fba
Test clear expired in the disc cache
vadymmarkov c03e22f
Test clear expired in the memory cache
vadymmarkov 2c1458f
Make internal
vadymmarkov 86e7091
Remove observer
vadymmarkov cee8c3a
Remove brackets
vadymmarkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import Foundation | ||
| import UIKit | ||
|
|
||
| public class HybridCache { | ||
|
|
||
|
|
@@ -16,6 +16,19 @@ public class HybridCache { | |
|
|
||
| frontStorage = StorageFactory.resolve(name, kind: config.frontKind, maxSize: config.maxSize) | ||
| backStorage = StorageFactory.resolve(name, kind: config.backKind, maxSize: config.maxSize) | ||
|
|
||
| let notificationCenter = NSNotificationCenter.defaultCenter() | ||
|
|
||
| notificationCenter.addObserver(self, selector: "applicationDidReceiveMemoryWarning", | ||
| name: UIApplicationDidReceiveMemoryWarningNotification, object: nil) | ||
| notificationCenter.addObserver(self, selector: "applicationWillTerminate", | ||
| name: UIApplicationWillTerminateNotification, object: nil) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💀 |
||
| notificationCenter.addObserver(self, selector: "applicationDidEnterBackground", | ||
| name: UIApplicationDidEnterBackgroundNotification, object: nil) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to remove these notifications at any time? |
||
| } | ||
|
|
||
| deinit { | ||
| NSNotificationCenter.defaultCenter().removeObserver(self) | ||
| } | ||
|
|
||
| // MARK: - Caching | ||
|
|
@@ -78,4 +91,38 @@ public class HybridCache { | |
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Notifications | ||
|
|
||
| func applicationDidReceiveMemoryWarning() { | ||
| frontStorage.clearExpired(nil) | ||
| } | ||
|
|
||
| func applicationWillTerminate() { | ||
| backStorage.clearExpired(nil) | ||
| } | ||
|
|
||
| func applicationDidEnterBackground() { | ||
| let application = UIApplication.sharedApplication() | ||
| var backgroundTask: UIBackgroundTaskIdentifier? | ||
|
|
||
| backgroundTask = application.beginBackgroundTaskWithExpirationHandler { [weak self] in | ||
| guard let weakSelf = self, var backgroundTask = backgroundTask else { return } | ||
|
|
||
| weakSelf.endBackgroundTask(&backgroundTask) | ||
| } | ||
|
|
||
| backStorage.clearExpired { [weak self] in | ||
| guard let weakSelf = self, var backgroundTask = backgroundTask else { return } | ||
|
|
||
| dispatch_async(dispatch_get_main_queue()) { | ||
| weakSelf.endBackgroundTask(&backgroundTask) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func endBackgroundTask(inout task: UIBackgroundTaskIdentifier) { | ||
| UIApplication.sharedApplication().endBackgroundTask(task) | ||
| task = UIBackgroundTaskInvalid | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.