Conversation
Contributor
Author
|
Travis is as always 😬 |
| ### SyncHybridCache | ||
|
|
||
| `Cache` is born to be async, but if for some reason you need to perform cache | ||
| operations synchronously, there is a helper for that. |
Contributor
There was a problem hiding this comment.
I think it should read;
Cache was born to be async.
Contributor
|
Travis... |
|
great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cacheis born to be async, so I've decided that there is no place for sync functions inCacheAwareprotocol, it kinda breaks the whole architecture of the library. But if for some reason you really need to perform cache operations synchronously (on your own risk 😄), there are helpers for that:SyncHybridCache for
HybridCacheHybridCache for type safe
CacheThis PR also adds source code documentation and this is nice 📖
Fixes #33