fix: Kurdish locale strings and formatted output contains non-standard kurdish characters#1848
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1848 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 180 181 +1
Lines 2034 2064 +30
Branches 524 537 +13
=========================================
+ Hits 2034 2064 +30
Continue to review full report at Codecov.
|
mhmd-azeez
approved these changes
Apr 9, 2022
Owner
|
Thanks. Would you please revert the change "move: arabic to english number maps into constants:"? I think it's better to put them inside each locale file. |
- fix usage of non-standard Kurdish characters in ku locale iamkun#1728 - add preparse and postformat to ku locale so that the formatted dates will contain correct Arabic numbers that Kurdish language uses.
Contributor
Author
|
@mhmd-azeez Thanks for the review, I really appreciate it. |
Contributor
Author
|
@iamkun Of course, done! |
Owner
|
Cool |
iamkun
pushed a commit
that referenced
this pull request
Apr 15, 2022
## [1.11.1](v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](#1806)) ([840ed76](840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](#1836)) ([627fa39](627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](#1831)) ([4e2802c](4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](#1829)) ([8e6d11d](8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](#1848)) ([a597d0b](a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](#1823)) ([e790516](e790516))
Owner
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arabic numbers are common in many
RTLlanguages, which makes sense forArabic->English andEnglish->Arabic` numbers mapping be factored out into a more general file so that other locales can import it and use it without the need to duplicate in the source code it.