Open
Conversation
iawia002
reviewed
Apr 7, 2020
Owner
iawia002
left a comment
iawia002
left a comment
There was a problem hiding this comment.
Sorry for the delay, can you please add support for downloading a single audio program, eg: https://www.qingting.fm/channels/226572/programs/8275727
| XVIDEOS | <https://xvideos.com> | ✓ | | | | | ||
| 聯合新聞網 | <https://udn.com> | ✓ | | | | | ||
| TikTok | <https://www.tiktok.com> | ✓ | | | | | ||
| 蜻蜓fm | <https://www.qingting.fm/> | | |✓ | | |
Owner
There was a problem hiding this comment.
Suggested change
| 蜻蜓fm | <https://www.qingting.fm/> | | |✓ | | | |
| 蜻蜓fm | <https://www.qingting.fm/> | | | ✓ | | |
| "github.com/iawia002/annie/utils" | ||
| "io/ioutil" | ||
| "net/http" | ||
| "strings" |
| "strings" | ||
| ) | ||
|
|
||
| type ChannelInfoApi struct { |
Owner
There was a problem hiding this comment.
Suggested change
| type ChannelInfoApi struct { | |
| type ChannelInfoAPI struct { |
| Name string | ||
| } | ||
|
|
||
| type ChannelAudioInfoApi struct { |
| channelInfoUrl := getChannelInfoUrl(channelId) | ||
| channelInfoResponse, err := http.Get(channelInfoUrl) | ||
| if err != nil { | ||
| fmt.Println("Error in fetching JSON") |
Owner
There was a problem hiding this comment.
Do not print logs here, just return the error
| audioInfoUrl := getChannelAudioInfoUrl(channelId) | ||
| response, err := http.Get(audioInfoUrl) | ||
| if err != nil { | ||
| fmt.Println("Error in fetching JSON") |
| Size: size, | ||
| } | ||
| return downloader.Data{ | ||
| Site: "qingting fm", |
Owner
There was a problem hiding this comment.
Suggested change
| Site: "qingting fm", | |
| Site: "蜻蜓FM qingting.fm", |
| return downloader.Data{ | ||
| Site: "qingting fm", | ||
| Title: title, | ||
| Type: "aduio", |
Owner
There was a problem hiding this comment.
Suggested change
| Type: "aduio", | |
| Type: "audio", |
iawia002
force-pushed
the
master
branch
4 times, most recently
from
dccdfc5 to
de872ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
add qingting.fm support
Does this pull request fix one issue?
Describe how you did it
many thanks for this project: https://github.com/koallen/qingting-dl
I just do some parsing job.
Describe how to verify it
already test for some channels
Special notes for reviews
Can not download for paid channels.