feat(programs): Add unique hashed ID for requirements#277
Open
lumakyns wants to merge 7 commits intoicssc:mainfrom
Open
feat(programs): Add unique hashed ID for requirements#277lumakyns wants to merge 7 commits intoicssc:mainfrom
lumakyns wants to merge 7 commits intoicssc:mainfrom
Conversation
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
2 times, most recently
from
384b064 to
a7c6013
Compare
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
a9fb47e to
696b2bc
Compare
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
696b2bc to
32d1ff6
Compare
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
32d1ff6 to
70d29ad
Compare
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
70d29ad to
a10d47d
Compare
laggycomputer
requested changes
Dec 20, 2025
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
apps/data-pipeline/degreeworks-scraper/src/components/AuditParser.ts
Outdated
Show resolved
Hide resolved
laggycomputer
requested changes
Dec 20, 2025
Member
laggycomputer
left a comment
laggycomputer
left a comment
There was a problem hiding this comment.
Commit messages (and therefore PR titles) must obey Conventional Commits.
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
a10d47d to
e75ffed
Compare
lumakyns
changed the title
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
2 times, most recently
from
6aa5494 to
2517795
Compare
laggycomputer
requested changes
Jan 4, 2026
Member
laggycomputer
left a comment
laggycomputer
left a comment
There was a problem hiding this comment.
Architecture is sane.
No new comments, but previous review comments have been updated and should be addressed first.
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
2517795 to
a41874f
Compare
laggycomputer
requested changes
Jan 5, 2026
| } | ||
|
|
||
| generateRequirementId(rule: Rule, childRequirementBlockIdentifier: string): string { | ||
| generateRequirementId(requirementType: string, coursesSalt: string): string { |
Member
There was a problem hiding this comment.
We also can't call this a "courses salt" because it's sometimes made up of requirement IDs instead!
Contributor
Author
There was a problem hiding this comment.
@laggycomputer Which of these seems best?
- ContentSalt
- RequirementSalt
- RequirementBlockSalt
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
2 times, most recently
from
9da7527 to
63af5d8
Compare
Member
|
I'm going to test this myself now... |
laggycomputer
requested changes
Feb 12, 2026
Member
laggycomputer
left a comment
laggycomputer
left a comment
There was a problem hiding this comment.
Finally tested this, so sorry.
Please resolve merge conflicts while I prepare for merge by migrating old requirement blocks forward.
lumakyns
force-pushed
the
enhancement/provide-block-id
branch
from
154b7b1 to
95fb9e0
Compare
Contributor
Author
@laggycomputer Done, let me know if any other changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to needing a unique id for individual requirements, and a unique id not being served by DegreeWorks, a hash consisting of a requirement's features was added.
The unique id is served as requirementId in the requirements column of
major,minor,specialization, andcollege_requirementtables.Additionally, due to jsonb's being too large for the unique index in
college_requirement, arequirements_hashcolumn was added to enforce uniqueness on.Related Issue
#185
Motivation and Context
Reason for unique id comes from issue.
How Has This Been Tested?
Scraper has been ran locally, database updates verified, and API calls tested for both rest and graphql
Screenshots (if appropriate):
N/A
Types of changes
Checklist: