[extensions] MucConfigFormManager: support persistentroom and roomdesc#695
Open
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Open
[extensions] MucConfigFormManager: support persistentroom and roomdesc#695stokito wants to merge 1 commit intoigniterealtime:masterfrom
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
…oom and muc#roomconfig_roomdesc This is often used fields.
Flowdalic
requested changes
Feb 13, 2026
Member
Flowdalic
left a comment
Flowdalic
left a comment
There was a problem hiding this comment.
LGTM, but please back out the integration test change.
We can add it later, but then with different strings for room name and description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is often used in
muc#roomconfig"basic" fields. At least they are used in the Spark.https://xmpp.org/extensions/xep-0045.html