Skip to content

build(deps): merge isort hooks#27

Merged
cesarcoatl merged 1 commit intomainfrom
build/deps/merge-isort
Apr 28, 2026
Merged

build(deps): merge isort hooks#27
cesarcoatl merged 1 commit intomainfrom
build/deps/merge-isort

Conversation

@cesarcoatl
Copy link
Copy Markdown
Member

@cesarcoatl cesarcoatl commented Apr 28, 2026

Summary by Sourcery

Build:

  • Simplify pre-commit isort configuration by removing the separate PyCQA/isort repo block and using the existing hook setup for stubs.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Consolidates the isort pre-commit hooks by removing the separate isort repo entry and relying on the existing isort hook configuration, leaving only hook-level configuration for stubs under the remaining repo section.

File-Level Changes

Change Details Files
Merge the isort hooks into a single repo configuration in pre-commit.
  • Remove the separate PyCQA/isort repo block from the pre-commit configuration
  • Keep the isort-stubs hook configuration but move it under the existing isort hooks section
  • Rely on the shared revision and repo settings for all isort-related hooks instead of duplicating them
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The isort-stubs hook is now nested under the first repo block without its own repo/rev, which likely breaks the YAML structure expected by pre-commit; consider explicitly keeping a single repo block with both hooks defined or adjusting indentation so the hooks are correctly associated.
  • If the goal is to truly merge the isort hooks, consider aligning their configuration (e.g., shared args and settings) or adding comments to clarify why isort-package and isort-stubs differ in options or target paths.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `isort-stubs` hook is now nested under the first repo block without its own `repo`/`rev`, which likely breaks the YAML structure expected by pre-commit; consider explicitly keeping a single repo block with both hooks defined or adjusting indentation so the hooks are correctly associated.
- If the goal is to truly merge the isort hooks, consider aligning their configuration (e.g., shared `args` and settings) or adding comments to clarify why `isort-package` and `isort-stubs` differ in options or target paths.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cesarcoatl cesarcoatl merged commit af01d12 into main Apr 28, 2026
5 checks passed
@cesarcoatl cesarcoatl deleted the build/deps/merge-isort branch April 28, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant