build(deps): merge isort hooks#27
Merged
cesarcoatl merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConsolidates the isort pre-commit hooks by removing the separate isort repo entry and relying on the existing isort hook configuration, leaving only hook-level configuration for stubs under the remaining repo section. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
isort-stubshook is now nested under the first repo block without its ownrepo/rev, which likely breaks the YAML structure expected by pre-commit; consider explicitly keeping a single repo block with both hooks defined or adjusting indentation so the hooks are correctly associated. - If the goal is to truly merge the isort hooks, consider aligning their configuration (e.g., shared
argsand settings) or adding comments to clarify whyisort-packageandisort-stubsdiffer in options or target paths.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `isort-stubs` hook is now nested under the first repo block without its own `repo`/`rev`, which likely breaks the YAML structure expected by pre-commit; consider explicitly keeping a single repo block with both hooks defined or adjusting indentation so the hooks are correctly associated.
- If the goal is to truly merge the isort hooks, consider aligning their configuration (e.g., shared `args` and settings) or adding comments to clarify why `isort-package` and `isort-stubs` differ in options or target paths.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Build: