feat: added simple check to graph_from_literal()#1981
Draft
schochastics wants to merge 3 commits intomainfrom
Draft
feat: added simple check to graph_from_literal()#1981schochastics wants to merge 3 commits intomainfrom
graph_from_literal()#1981schochastics wants to merge 3 commits intomainfrom
Conversation
schochastics
changed the title
graph_from_literal()
Contributor
|
Too risky, let's wait. |
maelle
reviewed
Sep 8, 2025
maelle
force-pushed
the
simplify-literal
branch
from
4ac7fde to
bb8d9da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #824
The PR implements the suggested additional check if a graph is simple or not.
This required a lot of adjustments in the tests given that this means that the edge order was changed. I could imagine that this might lead to issues downstream so keeping this for after the 2.2 release.
cc @szhorvat is this what you intended?