Skip to content

chore: remove stale TODOs in rinterface_extra.c #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krlmlr merged 3 commits into from
Apr 9, 2026
+0 −7
Merged

chore: remove stale TODOs in rinterface_extra.c #2601

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d92ec71
Initial plan
Copilot Mar 27, 2026
48327c2
chore: remove stale `/* TODO: serialization */` comments from `rinter…
Copilot Mar 27, 2026
8fcaa4c
Merge branch 'main' into copilot/check-todos-in-rinterface-extra-c
krlmlr Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/rinterface_extra.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,6 @@ igraph_error_t Rx_igraph_attribute_get_bool_graph_attr(const igraph_t *graph,
igraph_error_t Rx_igraph_attribute_get_string_graph_attr(const igraph_t *graph,
const char *name,
igraph_strvector_t *value) {
/* TODO: serialization */
SEXP gal=VECTOR_ELT(graph->attr, 1);
SEXP ga=Rx_igraph_getListElement(gal, name);

Expand All @@ -1323,7 +1322,6 @@ igraph_error_t Rx_igraph_attribute_get_numeric_vertex_attr(const igraph_t *graph
const char *name,
igraph_vs_t vs,
igraph_vector_t *value) {
/* TODO: serialization */
SEXP val=VECTOR_ELT(graph->attr, 2);
SEXP va=Rx_igraph_getListElement(val, name);
igraph_vector_t newvalue;
Expand Down Expand Up @@ -1371,7 +1369,6 @@ igraph_error_t Rx_igraph_attribute_get_bool_vertex_attr(const igraph_t *graph,
const char *name,
igraph_vs_t vs,
igraph_vector_bool_t *value) {
/* TODO: serialization */
SEXP val=VECTOR_ELT(graph->attr, 2);
SEXP va=Rx_igraph_getListElement(val, name);
igraph_vector_bool_t newvalue;
Expand Down Expand Up @@ -1410,7 +1407,6 @@ igraph_error_t Rx_igraph_attribute_get_string_vertex_attr(const igraph_t *graph,
const char *name,
igraph_vs_t vs,
igraph_strvector_t *value) {
/* TODO: serialization */
SEXP val, va;

val=VECTOR_ELT(graph->attr, 2);
Expand Down Expand Up @@ -1448,7 +1444,6 @@ igraph_error_t Rx_igraph_attribute_get_numeric_edge_attr(const igraph_t *graph,
const char *name,
igraph_es_t es,
igraph_vector_t *value) {
/* TODO: serialization */
SEXP eal=VECTOR_ELT(graph->attr, 3);
SEXP ea=Rx_igraph_getListElement(eal, name);
igraph_vector_t newvalue;
Expand Down Expand Up @@ -1496,7 +1491,6 @@ igraph_error_t Rx_igraph_attribute_get_bool_edge_attr(const igraph_t *graph,
const char *name,
igraph_es_t es,
igraph_vector_bool_t *value) {
/* TODO: serialization */
SEXP eal=VECTOR_ELT(graph->attr, 3);
SEXP ea=Rx_igraph_getListElement(eal, name);
igraph_vector_bool_t newvalue;
Expand Down Expand Up @@ -1535,7 +1529,6 @@ igraph_error_t Rx_igraph_attribute_get_string_edge_attr(const igraph_t *graph,
const char *name,
igraph_es_t es,
igraph_strvector_t *value) {
/* TODO: serialization */
SEXP eal=VECTOR_ELT(graph->attr, 3);
SEXP ea=Rx_igraph_getListElement(eal, name);

Expand Down
Loading