Draft
Conversation
Leftover from when we had the WAIT button
if original language is used.
It turned out that the Settings button is 1 pixel higher than the AUTO button.
2 tasks
Move status bar and battle settings to generateDefaultImages()
Owner
|
Hi @zenseii , can you please explain what is missing to be implemented in this pull request? Can we help to move forward with the changes or the idea? |
Collaborator
Author
|
@ihhub. There are 2 things necessary for this implementation to be ready:
Help with the first step would be appreciated and should be made in a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to and final part of #6105
This has been implemented:
For the Cyrillic font it looks quite good even though the buttons are slightly wider than the originals which means we have 15 pixels less for text:
Meanwhile, for the Latin font it is obvious that we have to cram the letters closer together. I found the sweet spot to be 2 pixels closer in the x-direction.
This is what it looks like for the Latin font without cramming:
Implementing a feature to cram letters would need a new function for calculating text width because it needs to take into account that the letters are rendered on top of each other, and we need a new function for actually rendering the text with letters on top of each other.
This change would give us 12 pixels more in width in the case when we have two words of 4 letters (ex. AUTO + SKIP), ( 2 pixels * ( 2 words * ( 4 letters - 1 first letter ) ) ). We would then only lose 3 pixels for text.
Such big changes might be better to do in a separate PR.
This change could be used to solve button problems like those described here #7548
This is what the SKIP button would look like with 2 pixels closer for letters.

Related to #9261