Open
Conversation
token.isValid() more strict, removed more common.ThrowError calls
Code Coverage ReportTotal Coverage: 25.6% Details
|
krankkkk
reviewed
Oct 23, 2025
Comment on lines
+33
to
44
| func CreateScopedTokenForEveryProject(projectNames []string) error { | ||
| var tokenError error | ||
| store := NewFileConfigStore() | ||
| tc := NewGopherTokenCreator() | ||
| for _, projectName := range projectNames { | ||
| GetScopedToken(projectName) | ||
| _, err := GetScopedToken(store, tc, projectName) // Getting tokens also caches them for later use | ||
| if err != nil { | ||
| return errors.Join(tokenError, err) | ||
| } | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This function seems to have alot of side effects.
GetScopedToken also seems to write somewhere, which it really shouldn't do.
CreateScopedTokenForEveryProject should probably only create a map[string]string projectName -> Token and then there should be another function that actually saves these token to disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the IAM package