Added installation instructions for FastBoot users#50
Merged
Conversation
c8b0350 to
7203bb8
Compare
7203bb8 to
1beb39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addon uses nullish coalescing operator
??, introduced in ECMA2020 (in June 2020) and natively supported in Node startingv14.0. Because Ember's blueprint forconfig/targets.jsuseslast 1 versionsfor browsers, there's a good chance that??doesn't get transpiled anymore.As a result, developers who use
ember-cli-fastbootandember-container-querycan encounter this build error:At a glance, it's not obvious what developers need to do to fix this error. (It certainly wasn't to me when I had encountered this error.) Based on Jeff's feedback in #49, I decided to explicitly mention what to do in the README.
References
SyntaxError: Unexpected tokenoccurs with nullish collascing operator ember-fastboot/ember-cli-fastboot#764