Add Makefile

[Toasterson]

Add a Makefile to help with packaging and building consistently

[citrus-it]

It would probably better if this was in illumos make and not GNU make, given its target audience.

[Toasterson]

I agree. But do you have a guide how to write those statements illumos make conform? I never found any.

[jclulow]

So I think this slightly different Makefile will work with either:

INSTALL = /usr/sbin/install
BINDIR = /usr/lib
MANIFESTDIR = /lib/svc/manifest/system

PRE_HASH = pre\#
HASH = $(PRE_HASH:pre\%=%)

SET_OWNER = $(HASH)
$(SET_OWNER)OWNER_BIN = -u root -g bin
$(SET_OWNER)OWNER_SMF = -u root -g sys

INSTALL_BIN = $(INSTALL) -s -f $(DESTDIR)$(BINDIR) $(OWNER_BIN) -m 0755
INSTALL_SMF = $(INSTALL) -s -f $(DESTDIR)$(MANIFESTDIR) $(OWNER_SMF) -m 0644

build: build-debug

build-debug:
	cargo build

build-release:
	cargo build --release

install-%: build-%
	mkdir -p $(DESTDIR)/usr/lib
	mkdir -p $(DESTDIR)/lib/svc/manifest/system
	$(INSTALL_BIN) target/$(@:install-%=%)/metadata
	$(INSTALL_BIN) userscript.sh
	$(INSTALL_SMF) metadata.xml
	$(INSTALL_SMF) userscript.xml

install: install-release

clean:
	cargo clean

You would use it thus:

• To install debug bits: make install-debug DESTDIR=/tmp/proto
• To install release bits: make install DESTDIR=/tmp/proto
• To install release bits and set user/group ownership: make install DESTDIR=/tmp/proto SET_OWNER=

[Toasterson]

Oh, nice. I like it. This is some awesome make foo.

I think I understand most. But what does the PRE_HASH/HASH bit do?

[jclulow]

I think I understand most. But what does the PRE_HASH/HASH bit do?

It is the only way of which I am aware to get a macro that contains just the # (hash) character. We then set SET_OWNER to the value of HASH, which means it too will expand to just a #. This means that this line:

$(SET_OWNER)OWNER_BIN = -u root -g bin

Will expand to:

#OWNER_BIN = -u root -g bin

Which means it is effectively commented out, and does nothing, leaving OWNER_BIN unset. If you override SET_OWNER to have no value, then it expands as:

OWNER_BIN = -u root -g bin

Which will set OWNER_BIN. All of this adds up to effectively making a behaviour conditional on arguments (or the environment, under some conditions) passed to make when it's invoked.

[Toasterson]

@jclulow Updated as suggested. also fixed the bug where SET_OWNER was not overridable as variable