Add resize() methods and an interpolate() method.#671
Open
ripytide wants to merge 1 commit intoimage-rs:mainfrom
Open
Add resize() methods and an interpolate() method.#671ripytide wants to merge 1 commit intoimage-rs:mainfrom
resize() methods and an interpolate() method.#671ripytide wants to merge 1 commit intoimage-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For image-rs/image#2238,
I've renamed
DynamicImage::resize()toresize_exact(),resize_to_fill()toresize_crop_to_fill()andimageops::resize()toresize_max_no_crop().I've added doc-tests, they're not amazing as they just use zeros at the moment but they're better than nothing.
As an aside:
imagehaving bothDynamicImage::resize()andimageops::resize()but them having different semantics,_max_no_crop()vs_exact(), seems like such a foot-gun and all the more reason image processing operations should be standardized in theimageproccrate and removed from theimagecrate.Since
resize()uses interpolation I also added apub interpolate(image, x, y, interpolation: Interpolation)method and also made the specific interpolation variant functions likeinterpolate_bilinear()public as well which should fix #546.