Append Metadata to metadata file using a file lock#605
Merged
Conversation
kkysen
force-pushed
the
kkysen/append-metadata-file-lock
branch
from
4ad6176 to
7073b06
Compare
kkysen
commented
Aug 12, 2022
oinoom
approved these changes
Aug 15, 2022
rinon
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586.
This uses
fs2file locking to append serializedMetadatas to the metadata file without race conditions. Thanks for the suggestion, @ahomescu!I'm unsure how to test for any race conditions, though.