[finaIcutpro]

For your pull request to not get closed without review, please confirm that:

• An issue exists where the maintainers agreed that this should be implemented
  (an approved feature request, or confirmed bug).
• I tested that my contribution works locally, and does not break anything,
  otherwise I have marked my PR as draft.
• If my contribution is non-trivial, I did not use AI to write most of it.
• I understand that I will be permanently banned from interacting with this
  organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

• Windows
• macOS
• Linux

---

I found it annoying to have to deal with exact word and case sensitive matching in the Cmd + F menu. This fixes that.

Screen.Recording.2026-10-19.at.9.51.37.PM.mov

[greptile-apps]

[Medium impact] The PR appears safe to merge; no new actionable issue was found.

_{Reviews (2) · Last reviewed commit: "more review fixes" · Reviewed by Greptile}

[finaIcutpro]

I have no further changes I want to make && am happy with the code. I believe this is ready to merge.

[helium-gardener]

Possibly related issues

These relationships were inferred from the effective change and may need maintainer confirmation:

• May be resolved by this PR: imputnet/helium#311 — Adds the requested case-sensitive find-bar switch and forwards its state to searches. It also implements the whole-word filter requested in the issue discussion.

[helium-gardener]

Found four actionable correctness issues involving cached iframe matches, PDF searches, and shared find-option state.

Review walkthrough

Changes

Files	Summary
patches/helium/core/find-exact-match.patch	Adds whole_word to Mojo find options and forwards it to Blink's active-match and scoping matchers. Reviewed renderer caching and the separate plugin/PDF path.
patches/helium/ui/find-bar-options.patch	Adds animated option rows, profile-level matching state, and search-session detection for option changes. Reviewed callbacks, ownership, focus handling, cross-window synchronization, and PDF restarts.
i18n/source.gen.json patches/series	Registers three matching UI strings and orders the renderer prerequisite before the UI patch, which follows the existing find-bar patch.

Review checks

Check	Result	Notes
Scope	✅ Passed	Confirmed four changed repository files and ten effective Chromium targets. No version transition or patch-application warnings; reported locations match reviewable provenance.
Project Policy	✅ Passed	Neither new patch changes upstream tests, test data, expectations, or test targets.
Correctness And Safety	⚠️ Finding	Identified stale renderer caches, two PDF integration defects, and unsynchronized shared controls. Reviewed desktop build wiring, lifetime, and incognito service separation.
Chromium Idioms	✅ Passed	The implementation uses existing Blink whole-word matching, Views builders, toggle controls, and animation APIs.
Simplicity And Decomposition	✅ Passed	The row helper and callbacks have local responsibilities; no separate actionable abstraction or decomposition concern.
Patch Organization	✅ Passed	Renderer support and UI integration are coherent patches, with prerequisites ordered correctly and UI work adjacent to the existing find-bar patch.

Analysis record

• Changed files considered: 4
• Findings: 4 new, 0 retained, 0 resolved
• Source snapshot: e5b1aeac84f7
• Codex: gpt-6.1-sol, reasoning max, fast mode on, web search cached
• Patch application: clean
• Chromium context tool calls: none
• Maintainer conventions applied: ignore-disabled-telemetry, preserve-incremental-loading, script-resource-lifecycle, ui-command-contexts, validate-supported-ui-paths, verify-runtime-selection-paths, visible-ui-anchors

Limitations

• Static inspection only; builds, tests, and interactive UI validation were not run.
• The supplied screenshots were available, but the PR's video attachment was unavailable.

[finaIcutpro]

all gardener suggestions have been triaged && resolved

[dumbmoron]

@wukko do ui review

[helium-gardener]

Found three actionable issues: a prohibited upstream test change and two PDF whole-word matching defects.

Review walkthrough

Changes

Files	Summary
patches/helium/ui/find-bar-options.patch i18n/source.gen.json	Adds an animated options panel, accessible switches, localized strings, profile-scoped matching state, observer synchronization, and matching-aware search sessions.
patches/helium/core/find-exact-match.patch	Routes whole-word matching through Blink's active search and scoping paths, updates zero-match caching, and extends PDF searching with option-aware resets and boundary filtering. The PDF changes introduce the three reported findings.
patches/series	Places matching support before its UI consumer and inserts the options patch immediately after the existing find-bar patch.

Review checks

Check	Result	Notes
Scope	✅ Passed	Reviewed all four changed repository files and their materialized source changes. No rebase was detected, and patch warnings are empty.
Project Policy	⚠️ Finding	The new core patch modifies an upstream PDF unit test.
Correctness And Safety	⚠️ Finding	PDF layout restarts discard whole-word mode, and selection-truncated text creates false word boundaries.
Chromium Idioms	✅ Passed	Uses existing FindBarState, ScopedObservation, Views controls and animation, Blink whole-word matching, and the base break iterator; required build dependencies are present.
Simplicity And Decomposition	✅ Passed	Profile/UI state and engine matching support form one coherent feature with no additional actionable structural issue.
Patch Organization	✅ Passed	Patch responsibilities and prerequisite ordering are coherent; the UI patch is adjacent to its existing find-bar prerequisite.

Analysis record

• Changed files considered: 4
• Findings: 3 new, 0 retained, 0 resolved
• Source snapshot: 6092405b2a32
• Codex: gpt-6.1-sol, reasoning max, fast mode on, web search cached
• Patch application: clean
• Chromium context tool calls: none
• Maintainer conventions applied: ignore-disabled-telemetry, preserve-incremental-loading, script-resource-lifecycle, ui-command-contexts, validate-supported-ui-paths, verify-runtime-selection-paths, visible-ui-anchors

Limitations

• Static inspection only; no builds, tests, or runtime reproduction were performed.
• The PR video attachment was unavailable; the supplied screenshots were inspected.

[finaIcutpro]

resolved

[finaIcutpro]

@greptileai review