Generating derived data sources from habitatmap_2025#84
Open
Generating derived data sources from habitatmap_2025#84
Conversation
An essential aspect is that these attributes better go to the object with the geometries, not to the long table with the types.
Member
Author
|
@cecileherr @ToonHub a first release candidate of Notable updates for the 2025 version are:
The data source version is supported by {n2khab} in branch |
cecileherr
reviewed
Mar 27, 2026
cecileherr
reviewed
Mar 27, 2026
cecileherr
approved these changes
Mar 30, 2026
Collaborator
cecileherr
left a comment
cecileherr
left a comment
There was a problem hiding this comment.
I did not check activate.R, but the rest of the code looks fine to me.
Many thanks for the update!
Since habitat with small surface can have phab = 0, we should not consider polygons where terrestrial types have phab = 0 and an aquatic type has phab > 0 as purely aquatic. This results in a more conservative outcome for habitatmap_terr, by still including such polygons.
This does not change the result; this is just an attempt to modernize and streamline the steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is work in progress.
For now, @ToonHub and @cecileherr it's useful already to have a look at the habitatmap_stdized code that derives the new columns
year_assessmentandmethod_assessmentin order to fix #74 (these column names can also be reconsidered).I'm also waiting for some feedback on "mk" and "n" codes to further amend this.(UPDATE 26 March: is tackled in e8de9a9 and 8be0675) The code has been derived from initial code created by @WardTamsyn.Also fixes #72.
This PR will grow in steps and I may call for some feedback intermittently.
In this top comment, the most up to date rendered HTML files are attached: