Fixed #226: Removes demo ENV check from UsersController#227
Open
ntaylor-86 wants to merge 1 commit intoinertiajs:masterfrom
Open
Fixed #226: Removes demo ENV check from UsersController#227ntaylor-86 wants to merge 1 commit intoinertiajs:masterfrom
ntaylor-86 wants to merge 1 commit intoinertiajs:masterfrom
Conversation
The demo app is not using `APP_ENV=demo`, allowing anyone to update John Doe's password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #226
The deployed demo app https://demo.inertiajs.com/ is not using
APP_ENV=demo, allowing anyone to update the demo users John Doe's password.This PR removes the ENV check ensuring no one can update John Doe's password and breaking the login for everyone else.