-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: add trailing slashes to Toggle component documentation URLs #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: add trailing slashes to Toggle component documentation URLs #3022
Conversation
|
Hey @majiayu000 - thanks for the PR. I don't think this actually resolves #3021, nor do I have any issue with the missing trailing slashes. The docs site redirects correctly. I think the original issue was saying the documentation itself is out of date. |
coolsoftwaretyler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't actually fix the original issue. Did you want to take a shot at improving the docs?
|
Hi maintainers, I noticed that Issue #3021 mentions the documentation content might be outdated (referring to an old version of the component before it was moved to Toggle). My PR currently only fixes the trailing slash in the documentation URLs. I wanted to clarify:
Please let me know if any additional changes are needed. Thanks! |
|
H3y @majiayu000:
|
- Add explanation that Radio is part of the Toggle component system - Document the inputDetailStyle prop for customizing the dot indicator - Add usage example Fixes infinitered#3021
93cb145 to
d86d0d5
Compare
|
Thanks for the feedback! I've updated the PR to actually improve the Radio documentation:
Let me know if you'd like any other adjustments! |
|
Thanks @majiayu000 - I'll take a look. |
|
Hey @majiayu000 - let's hold off on changes for now. I'm trying to understand the initial issue better, so I'm not sure what (if anything) we ought to change in the docs. |
|
@coolsoftwaretyler , I know. If you have any idea you can tell me. I can change this pr or close it . |
Summary
Updated the Radio component documentation to clarify its relationship with the Toggle component system.
Changes Made
inputDetailStyleprop for customizing the dot indicatorFixes #3021