Japx.Decoder.Options to exclude relationships if it's empty#43
Merged
Conversation
Truba
approved these changes
Aug 23, 2021
Co-authored-by: Vlaho Poluta <v.poluta@hotmail.com>
fgulan
approved these changes
Sep 2, 2021
fgulan
left a comment
Member
There was a problem hiding this comment.
@MadGeorge excellent job! 🎉 Could you just please resolve the merge conflict and we'll merge this right away. It will be included in next release this week.
Co-authored-by: Filip Gulan <gulan.filip@gmail.com>
Contributor
Author
Suddenly there is no option to resolve conflicts from web ui. Need time to understand how to do it manually. |
Contributor
|
Hi @MadGeorge, if it is fine with you, I can take it from there and resolve the merge conflict. |
Contributor
Author
Hello. totally fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

According to the JSON:API docs:
Current implementation breaks this requirement.
An empty JSON object will be sent when no relationships are provided.
This leads to API incompatibility with servers with strict validation rules on incoming request data.
The solution we introduce is the encoding option to exclude "relationships" object if it's empty.
Since other apps may rely on current library behavior, we leave the default option to send the empty object, so it will not require any changes on update.