influxdb/src/query: Send uints as unsigned integers on the line protocol (u suffix instead of i)#113
Merged
Merged
Conversation
Collaborator
Don't mind them, I believe we should pin the clippy version so that newly introduced lints don't fail PRs with unrelated changes (see #114). |
Collaborator
|
I have merged #114 to main, you can rebase and run the CI. |
…fix instead of `i`)
Contributor
Author
|
@Empty2k12 done, pushed up the rebase |
Contributor
Author
|
FWIW, I do still get these on nightly: Stable looks clean, though :) |
Collaborator
|
Thanks! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we serialize
u8/u16/u32/u64fields as signed integers in the line protocol (e.g.82i). This changes them to send as unsigned integers (e.g.82u)It might make sense for this be opt-in behavior, or at the very least a breaking change as far as semver is concerned (e.g. v0.6.0); unsigned integer support wasn't merged into influxdb until 1.4.0, so users with sufficiently old versions of influxdb could have a bad experience.
Quick note - I did run clippy and it fails on a few things, but nothing I changed. I can include fixes if desired, but I didn't want to tack on unrelated changes that might be considered out of scope - let me know!
Checklist
cargo fmt --allcargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warningscargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warningscargo readme -r influxdb -t ../README.tpl > README.md