Skip to content

fix(keepers): use consistent routing for OPinit#520

Merged
traviolus merged 1 commit into
mainfrom
fix/opinit-route
May 15, 2026
Merged

fix(keepers): use consistent routing for OPinit#520
traviolus merged 1 commit into
mainfrom
fix/opinit-route

Conversation

@traviolus
Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@traviolus traviolus requested a review from a team as a code owner May 15, 2026 08:48
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 545407e2-cb8e-4962-96d5-d6367fc26ac0

📥 Commits

Reviewing files that changed from the base of the PR and between f4b5e81 and 3e4acb1.

📒 Files selected for processing (1)
  • app/keepers/keepers.go

📝 Walkthrough

Walkthrough

The IBC router registration in NewAppKeeper is updated to register the OPHost module using ophosttypes.PortID as the route key instead of ophosttypes.ModuleName, while the routed handler (ophostStack) remains unchanged.

Changes

IBC Router OPHost Registration

Layer / File(s) Summary
OPHost IBC router registration update
app/keepers/keepers.go
IBC router route key for OPHost module is switched from ModuleName to PortID as the route identifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single line change, small but precise,
From ModuleName to PortID so nice,
The router now finds OPHost by its port,
A routing redirect of the technical sort,
One hop on the blockchain highway! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is a generic template with unchecked checklist items and lacks specific details about what the fix addresses, why it's needed, or what changes were made. Provide a clear description of the routing inconsistency being fixed, the specific issue it resolves, and why using PortID instead of ModuleName is the correct approach.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(keepers): use consistent routing for OPinit' accurately describes the main change: updating the IBC router to use consistent routing for the OPHost module by changing from ModuleName to PortID.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/opinit-route

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traviolus traviolus merged commit 3f888ac into main May 15, 2026
12 checks passed
@traviolus traviolus deleted the fix/opinit-route branch May 15, 2026 09:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.39%. Comparing base (f4b5e81) to head (3e4acb1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/keepers/keepers.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   38.39%   38.39%           
=======================================
  Files         327      327           
  Lines       30676    30676           
=======================================
  Hits        11779    11779           
  Misses      17006    17006           
  Partials     1891     1891           
Files with missing lines Coverage Δ
app/keepers/keepers.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants