174 feat add mgf file support for mztab data loader#178
Open
JemmaLDaniel wants to merge 2 commits intomainfrom
Open
174 feat add mgf file support for mztab data loader#178JemmaLDaniel wants to merge 2 commits intomainfrom
JemmaLDaniel wants to merge 2 commits intomainfrom
Conversation
…ZTabDatasetLoader
… for MZTabDatasetLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MZTabDatasetLoaderto accept.mgfspectrum files (viamatchms) alongside the existing.parquetand.ipcformatsadd_index_colsparameter (defaulting to true inmztab.yaml) that generatesexperiment_nameandspectrum_idcolumns, enabling downstream features that requirespectrum_id_df_from_matchms,_add_index_cols) fromInstaNovoDatasetLoaderinto module-level functions reused by both loadersThe generated
spectrum_id({file_stem}:{row_index}) aligns with the 0-basedindex=Nextracted from MZTabspectra_ref, so Casanovo and other MZTab-producing engines are correctly mapped to their input spectra without changing the existing join semantics.