[MBL-19382][S] Student annotation toolbar #3860
Merged
+10
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-19382 builds: Student affects: Student release note: none
petkybenedek
requested review from
rh12,
suhaibabsi-inst and
vargaat
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR simplifies the toolbar button implementation by removing a workaround for SwiftUI font weight overriding and adopts the toolbarItemForegroundStyle custom view modifier pattern that's already being used elsewhere in the codebase.
Positive Feedback ✅
- Good refactoring: Removes the hacky workaround with the hidden image (
Image.assignmentLine.frame(width: 0, height: 0).clipped()) which was only there to prevent nav bar font weight override - Consistent pattern: Uses
toolbarItemForegroundStyle, which is the established pattern in the codebase (seen inSpeedGraderScreen.swift,GradeListScreen.swift, etc.) - Cleaner code: Simplifies the
doneButtonimplementation by removing the unnecessaryHStackwrapper - Better SwiftUI practices: Using the trailing closure syntax for buttons is cleaner and more idiomatic
- iOS 26 ready: The custom
toolbarItemForegroundStylemodifier handles iOS 26 compatibility gracefully
Issues Found 🔧
- Extra blank line at Student/Student/Submissions/StudentAnnotationSubmission/StudentAnnotationSubmissionView.swift:60 should be removed
The change is well-aligned with the project's goals of removing SwiftUI workarounds and maintaining code quality.
Student/Student/Submissions/StudentAnnotationSubmission/StudentAnnotationSubmissionView.swift
Outdated
Show resolved
Hide resolved
Contributor
Contributor
BuildsCommit: Remove newline (096ae34)
|
suhaibabsi-inst
approved these changes
Jan 27, 2026
Contributor
suhaibabsi-inst
left a comment
suhaibabsi-inst
left a comment
There was a problem hiding this comment.
QA +1
Tested on iPhone 16, iOS 26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-19382
builds: Student
affects: Student
release note: none
Test plan
Submit a Student Annotation assignment. The toolbar buttons should not be misaligned and should appear correctly.
Screenshots
Checklist