Skip to content

Remove fatal error for non mobile platform #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spandruvada wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −8
Open

Remove fatal error for non mobile platform #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/thd_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ int cthd_engine::check_acpi_platform_profile() {
pm_profile_fs.read("", pm_profile);
thd_log_info("PM profile is %s\n", pm_profile.c_str());
if (pm_profile != "2" && pm_profile != "8") {
thd_log_error("Non mobile platform, exiting..\n");
return THD_FATAL_ERROR;
thd_log_warn("Non mobile platform, thermal tables may not have been validated.\n");
return THD_ERROR;
}
Comment on lines 262 to 266

@spandruvada spandruvada Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking to turn this function to void

} else {
thd_log_info("PM profile is not available, skipping check\n");
Expand Down Expand Up @@ -297,9 +297,7 @@ int cthd_engine::thd_engine_init(bool ignore_cpuid_check, bool adaptive) {
thd_log_debug("Ignore CPU ID check for MSRs\n");
proc_list_matched = true;
} else {
if (check_acpi_platform_profile() != THD_SUCCESS) {
return THD_FATAL_ERROR;
}
check_acpi_platform_profile();

check_cpu_id();

Expand Down
4 changes: 1 addition & 3 deletions src/thd_engine_adaptive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,9 +660,7 @@ int cthd_engine_adaptive::thd_engine_init(bool ignore_cpuid_check,
size_t size;
int res;

if (check_acpi_platform_profile() != THD_SUCCESS) {
return THD_FATAL_ERROR;
}
check_acpi_platform_profile();

thd_parse_features();

Expand Down
Loading